Target localhost by default if $PORT is set, closes #146. #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `$PORT` env variable is set, the URL defaults to
`localhost:PORT/path`. You can pass a bare path for the URL.
This allows doing:
0x --on-port 'autocannon /path' -- node server.js
Merged
mcollina
approved these changes
Jul 20, 2018
| @@ -5,6 +5,7 @@ | |||
| const minimist = require('minimist') | |||
| const fs = require('fs') | |||
| const path = require('path') | |||
| const URL = require('url').URL | |||
There was a problem hiding this comment.
Can you throw an error if URL is not available?
Was trying to use `argv.url` when it may not exist.
|
Can you please update the docs as well? CI is still failing :(. |
|
CI failures seem like the same as in #145 (comment). It passed on Node 6 and 10 this time and failed on 8, looks like flakiness. I think it would be easiest to fix it in #144 to prevent merge conflicts. |
|
🎉 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
$PORTenv variable is set, the URL defaults tolocalhost:PORT/path. You can pass a bare path for the URL.This allows doing:
When an invalid URL is given, autocannon now logs an error and exits.
(
/pathwithout a$PORTis an invalid URL.)It uses the URL API which was backported to Node 6.13.0, if lower
versions of Node 6 should be supported I can change it to use
url.parseandurl.formatinstead.