-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V4: build failing with latest bootstrap#v4-dev #1045
Comments
@FezVrasta that's all the time I can give this today. If you can solve If alpha 3 is published, that is our best bet and they have promised that this is solved for that release. |
Sorry what's the point Imho there aren't problems in waiting for BS to fix on their side, no rush. |
|
4.0.0-alpha.3 npm package does not contain es6 sources, a cjs or umd bundle. |
shit :/ will have to wait then.. |
Our blocking issue is being tracked at twbs/bootstrap#20418 |
Updating the status here: As temporary workaround, FezVrasta/bootstrap-material-design@622fbab is working just fine and allows us to make the build pass. Still waiting for Bootstrap to reintroduce the javascript source tho. |
Latest v4-dev of BS includes the sources, this fixes our problem. |
Locally it passes, on travis it fails. I'm investigating the issue |
Ok nice, now even locally I get:
@rosskevin I thought you had fixed it, do you have any clue? It's freaking weird that even after I reverted the changes the build is still failing locally.. let's see on Travis.. PS. Failing even on Travis... maybe it's some dependency that got updated and broke the build... |
Ok it's babel-preset-es2015, the newest version breaks something. The 6.9.0 works just fine.. @rosskevin do you know where should we report this problem? |
Passing both locally and on TravisCI.. for now I'll keep 6.9.0.. I don't have the knowledge to dive into the build system built by Ross |
Seems like we could fix the problem with this suggestion? |
@rosskevin I can't really understand how the build system you built works... I'm thinking about rewriting it from scratch with Grunt and nothing else, I don't really see the advantages of using all this complex stuff just to run rollup and few commands... |
I have no objections. |
Bootstrap didn't publish umd or src in the latest builds:
twbs/bootstrap#18934
New builds are currently not working. I do see that they intend to publish js modules in alpha 3, just not sure what to do in the interim.
Unfortunately, npm isn't pulling the full repo source like it used to based on
"bootstrap": "twbs/bootstrap#v4-dev"
, otherwise I could just add theirjs
source to our transpilation pipeline.We need to get back to a place where either:
a) bootstrap is publishing modules in the npm package; or
b) npm will pull the
js
source from the repo like I instruct it to! (not sure why this has changed)The text was updated successfully, but these errors were encountered: