Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome Update Breaks Scroll Behavior #367

Open
escherlies opened this issue Sep 26, 2024 · 2 comments
Open

Chrome Update Breaks Scroll Behavior #367

escherlies opened this issue Sep 26, 2024 · 2 comments
Labels
has-ellie This is a bug and has an ellie which demonstrates it.

Comments

@escherlies
Copy link
Contributor

Bug

Screenshot 2024-09-26 at 14.05.30

After a recent Chrome update, we have noticed that the scroll behavior is broken.

Ellie example: https://ellie-app.com/smLZnK4J7cta1

Expected Behavior
The scrollable container should scroll and not overflow.

Investigation
At first glance, the Chrome behavior of min-height: min-content might have changed. Adding min-height: unset to the element with the scrollbars attribute fixes the problem on Chrome (see Ellie).

Screenshot 2024-09-26 at 14.05.54

Versions

  • OS: macOS and Windows
  • Browser: Chrome/Chromium-based browsers
  • Browser Version: Version 129.0.6668.71 (Official Build) (arm64)
  • Elm Version: [Please specify the version number]
  • Elm UI Version: [Please specify the version number]
@github-actions github-actions bot added the has-ellie This is a bug and has an ellie which demonstrates it. label Sep 26, 2024
ahankinson added a commit to rism-digital/muscatplus_ui that referenced this issue Oct 1, 2024
The latest version of Chrome breaks the scrolling of div elements. This hotfix applies the workaround in mdgriffith/elm-ui#367
@Viir
Copy link

Viir commented Oct 2, 2024

Thank you for sharing this fix!

This issue and corresponding mitigation is also discussed on the chromium issue tracker at https://issues.chromium.org/issues/368634145

@Viir
Copy link

Viir commented Oct 6, 2024

Today, I learned more about mitigating the scrollbar issue that has appeared with Chrome 129.
At first, I tried to add the min-height: min-content in several affected applications. This restored scrollbars in many cases, but I noticed that in some cases, scrollbars were still missing in elements with the .scrollbarY attribute.

Therefore, I tested removing the min-height: min-content and adding contain: size instead. This setter worked better in my apps.

But even after this improvement, I noticed a case where the behavior differed from earlier combinations. In one case, I had an Element.scrollbarY in a function reused from two different views. One of these parent views also applies Element.scrollbarY. As far as I remember, that inner element took available height in earlier versions, but not anymore with Chromium 129 combined with said change in CSS. So, in that case, I also had to take care to remove the nested Element.scrollbarY.

Viir added a commit to Viir/bots that referenced this issue Oct 6, 2024
Fix the issue of disappearing scrollbars that appeared with the rollout of Chromium 129, as discussed at <mdgriffith/elm-ui#367 (comment)> and <https://issues.chromium.org/issues/368634145>
Since the BotLab client software uses the Evergreen distribution mode of WebView2, the GUI has been affected by the rollout of the shared implementation.
jumper149 added a commit to jumper149/mensam that referenced this issue Oct 12, 2024
This thread revolves around this issue with elm-ui:
mdgriffith/elm-ui#367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-ellie This is a bug and has an ellie which demonstrates it.
Projects
None yet
Development

No branches or pull requests

2 participants