Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api.EventTarget.addEventListener - options.signal is supported on node.js #18883

Closed
gamliela opened this issue Feb 11, 2023 · 1 comment · Fixed by #20889
Closed

api.EventTarget.addEventListener - options.signal is supported on node.js #18883

gamliela opened this issue Feb 11, 2023 · 1 comment · Fixed by #20889
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Comments

@gamliela
Copy link

What type of issue is this?

Incorrect support data (ex. Chrome says "86" but support was added in "40")

What information was incorrect, unhelpful, or incomplete?

Node.js supports options.signal since version 18. However docs say it doesn't.

What browsers does this problem apply to, if applicable?

Node.js

What did you expect to see?

18

Did you test this? If so, how?

No, sorry. Just looked at the docs.

Can you link to any release notes, bugs, pull requests, or MDN pages related to this?

Node docs: https://nodejs.org/docs/latest-v18.x/api/events.html#eventtargetaddeventlistenertype-listener-options

Do you have anything more you want to share?

No response

MDN URL

https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener

MDN metadata

MDN page report details
  • Query: api.EventTarget.addEventListener
  • Report started: 2023-02-11T06:05:32.791Z
@queengooborg queengooborg added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Feb 11, 2023
@Cipscis
Copy link
Contributor

Cipscis commented Oct 3, 2023

Here's a link to the relevant automated comment where the PR adding this support was merged in the Node project, in December 2020: nodejs/node#36258 (comment)

That's almost two years before Node 18 was launched, which makes me wonder if support was added in an earlier version of Node than 18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants