Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @import … supports() support #22164

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Update @import … supports() support #22164

merged 4 commits into from
Feb 13, 2024

Conversation

bramus
Copy link
Contributor

@bramus bramus commented Feb 5, 2024

👋 Hi, Chrome DevRel here

@import … supports() shipped in Chrome 122.

Links:

Note that ChromeStatus mentions it shipping in 121 but that’s not the case. The flag only got flipped in commit 6ca8ac7e347b73c62609643164a444719f9d26f7, which is only included in M122. See https://chromiumdash.appspot.com/commit/6ca8ac7e347b73c62609643164a444719f9d26f7 for details.

@github-actions github-actions bot added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Feb 5, 2024
@skyclouds2001
Copy link
Contributor

this is dumplite with #22163

@romainmenke
Copy link
Contributor

romainmenke commented Feb 5, 2024

Let's merge this one instead of mine, it better documents why it doesn't (yet) work in Chrome 121.

What are the odds that we both opened a change for this, so close together :D

@bramus
Copy link
Contributor Author

bramus commented Feb 5, 2024

Let's merge this one instead of mine, it better documents why it doesn't (yet) work in Chrome 121.

This PR relies on #22165 getting merged in first though, as it refers to the Chromium Issue Tracker using the new URL format.

(@ reviewer: To unblock this PR, I can change the impl_url to use the crbug.com prefix if needed, as those URLs still work as well)

What are the odds that we both opened a change for this, so close together :D

I tend to subscribe to the (to me) relevant bugs :) – Thanks for leaving your original reply, as we got it wrong there indeed.

@bramus
Copy link
Contributor Author

bramus commented Feb 6, 2024

As there is some ongoing discussion in #22165 I have updated the URL to the crbug.com format. That way, this PR can be approved/merged separately.

@romainmenke
Copy link
Contributor

Webkit also implemented this and it is available in the latest Technology Preview : WebKit/WebKit@8338db4

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! LGTM as is. Do you want to set safari to "preview"?

@bramus
Copy link
Contributor Author

bramus commented Feb 13, 2024

Do you want to set safari to "preview"?

Done.

@Elchi3
Copy link
Member

Elchi3 commented Feb 13, 2024

Even better, thank you! 👍

@Elchi3 Elchi3 merged commit 4db79a0 into mdn:main Feb 13, 2024
6 checks passed
@bramus bramus deleted the import-supports branch September 10, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants