Added stable sub-feature for Array.prototype.sort. #4559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elchi3
added
the
data:js
jpmedley
suggested changes
Aug 1, 2019
jpmedley
approved these changes
Aug 1, 2019
evilpie
reviewed
Aug 5, 2019
It appears Edge support is right around the corner. We can change Edge's version when it lands. See 4b00797. This commit can be squashed if merged.
ddbeck
approved these changes
Aug 5, 2019
Contributor
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
Looks great. Thank you! 🎉
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the current ECMAScript spec (and since version 10),
Array.prototype.sortmust be stable.It seems sorting has been stable in Firefox since version 3 (bugzilla). I assume this means it has been in Firefox for Android since its birth.
Sorting is currently stable in V8, and according to v8.dev it has landed in Chrome 70 and Node.js 12. However, it seems Node.js 11 includes V8 7.0 (changelog of Node.js). So it might have landed as early as Node.js 11.
Sorting is currently stable in Chakra Core (PR #5724 in ChakraCore), but I can't find in which version of Edge this landed.
According to a post on StackOverflow, sorting has been stable in Opera since 10, Safari since 4, and IE since 6, but I have no other sources to back up these claims.