Add top-level await #7209
Merged
Add top-level await #7209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:js 📟
github-actions
bot
added
the
data:browsers 🌍
|
Looking good to me! Just a little nitpick to keep the scope of the PR small, can we separate the browser file changes into its own separate PR? |
5 tasks
ddbeck
removed
the
data:browsers 🌍
ddbeck
requested changes
Nov 5, 2020
There was a problem hiding this comment.
A couple of minor issues in line comments, but otherwise good. Thank you, @saschanaz!
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
ddbeck
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A checklist to help your pull request get merged faster: