-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix non-standard File System related API #15815
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sideshowbarker
approved these changes
May 10, 2022
yin1999
added a commit
to yin1999/translated-content
that referenced
this pull request
Aug 1, 2022
yin1999
added a commit
to mdn/translated-content
that referenced
this pull request
Aug 2, 2022
* Drop Canvas hit regions content follow mdn/content#8226 * remove non-standard File System related API follow mdn/content#15815 * Demix cancel event from GlobalEventHandlers follow mdn/content#18115 * Remove IDBEnvironment mixin page follow mdn/content#8495 * Remove RenderingContext typedef follow mdn/content#6592 * Remove Transferable from MDN follow mdn/content#8880 * remove Window.isSecureContext follow mdn/content#8351 * remove standard table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last Q3, in #8379, @sideshowbarker cleaned a lot of existing standard file-related APIs. This was a huge improvement on what we had until then.
We still have a problem with non-standard entries that are intertwined with them, as well as with a sidebar that describes the non-standard version but is also, sometimes, used for the modern APIs.
This PR aims to fix this (there will be still work to bring the actual content of the modern APIs to completion, but this is a huge improvement already, so it is worth limiting us to this.
This is what has been done here:
FileException
that was Chrome-only, behind a prefix, and deleted in Chrome 29. It is now redirected to the File_and_Directory Entries API overview page.LocalFileSystem.*
andLocalFileSystemSync.*
. I didn't find any mention of it, no bcd. They are now redirected to the File_and_Directory Entries API overview page.Metadata
is implemented in Chromium, but is no more part of the File and Directory Entries API. I'm using this sidebar now without addingMetadata
to it.Metadata
will be accessible (via the non-standard and documentedFileSystemEntry.getMetadata()
method), but not discoverable (as no more on the standard track and not interoperable, this is good). I also cleaned the spec text and the intro note.FileRequest
,LockedFile
andFileHandle
. They are no more on the standard track and have been renamed toIDBFileEvent
,IDBFileHandle
, andIDBMutableHandle
. I moved the page and updated them (events for example). I added a clear note pointing to use File and Directory Entries API. Note thatIDBFileRequest
is the last interface implementingDOMRequest
that we deleted from MDN long ago. I have not resurrected it, but have explained thethen()
method inIDBFileRequest
.IDBMutableFile.getFile()
has been removed in Firefox 74. I deleted the page and its mention. It is now a Redirect.File System API
that was mixing both old and new versions of the API.File and Directory Entries API
sidebar.File System API
entry fromGroupData.json
as it is no more used.There are a lot of improvements to do in the different APIs, but I think we have a good structure now and fewer skeletons in the closet (this is also removing about 100 flaws...)