Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): update italic font variation example #37173

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

OnkarRuikar
Copy link
Contributor

The font-syntheis: none prevents the p1 paragraph from getting synthesized italics font. The intention was to demo the font-synthesis property.

To prevent confusion, by default, we show italics font and keep the synthesis none line commented and ask readers to play with it.

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner December 11, 2024 02:29
@OnkarRuikar OnkarRuikar requested review from estelle and removed request for a team December 11, 2024 02:29
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/xs [PR only] 0-5 LoC changed labels Dec 11, 2024
Copy link
Contributor

github-actions bot commented Dec 11, 2024

Preview URLs

(comment last updated: 2024-12-12 20:00:53)

@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Dec 12, 2024
@OnkarRuikar OnkarRuikar requested a review from estelle December 12, 2024 04:50
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit 498b20f into mdn:main Dec 12, 2024
8 checks passed
@OnkarRuikar OnkarRuikar deleted the css_font-synthesis branch December 13, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font style Italic
2 participants