Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 37154: samesite description #37189

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Fix issue 37154: samesite description #37189

merged 2 commits into from
Dec 13, 2024

Conversation

wbamberg
Copy link
Collaborator

Fixes #37154.

@wbamberg wbamberg requested a review from a team as a code owner December 12, 2024 05:45
@wbamberg wbamberg requested review from hamishwillee and removed request for a team December 12, 2024 05:45
@github-actions github-actions bot added Content:Security Security docs size/xs [PR only] 0-5 LoC changed labels Dec 12, 2024
Copy link
Contributor

github-actions bot commented Dec 12, 2024

Preview URLs

(comment last updated: 2024-12-13 18:26:13)

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is clearly correct, but one query/suggestion here: https://github.com/mdn/content/pull/37189/files#r1883166075

Approving so you can merge when you have had a look at that.

…es/index.md

Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
@wbamberg
Copy link
Collaborator Author

Thanks! I think there are potentially more issues and improvements to the page but in the current PR I only wanted to fix this, which AFAICS is just an error.

@wbamberg wbamberg merged commit 58e3ead into mdn:main Dec 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Security Security docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SameSite behaviour incorrectly described in the Security/Practical Implementation Guide for cookies
2 participants