Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WindowOrWorkerGlobalScope mixin page #8796

Merged
merged 2 commits into from
Sep 11, 2021
Merged

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Sep 10, 2021

Follow up to #8351

Removing the mixin page as it has no sub pages anymore.

@Elchi3 Elchi3 requested a review from a team September 10, 2021 08:00
@Elchi3 Elchi3 requested review from a team as code owners September 10, 2021 08:00
@Elchi3 Elchi3 requested review from fiji-flo, teoli2003 and sideshowbarker and removed request for a team September 10, 2021 08:00
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 5 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Window
Title: Window
on GitHub
Flaw count: 32

  • macros:
    • /en-US/docs/Web/API/Window/DOMMatrix does not exist
    • /en-US/docs/Web/API/Window/DOMMatrixReadOnly does not exist
    • /en-US/docs/Web/API/Window/DOMPoint does not exist
    • /en-US/docs/Web/API/Window/DOMPointReadOnly does not exist
    • /en-US/docs/Web/API/Window/DOMQuad does not exist
    • and 18 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/The_message_manager
    • Can't resolve /en-US/docs/Mozilla/Tech/XUL/Attribute/onpagehide
    • Can't resolve /en-US/docs/Mozilla/Tech/XUL/Attribute/onpageshow
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 1 more flaws omitted

URL: /en-US/docs/Web/API/WorkerGlobalScope
Title: WorkerGlobalScope
on GitHub
Flaw count: 3

  • macros:
    • /en-us/docs/web/api/globalcrypto (url: /en-US/docs/Web/API/GlobalCrypto) does not exist
    • /en-US/docs/Web/API/WorkerGlobalScope/onrejectionhandled does not exist
    • /en-US/docs/Web/API/WorkerGlobalScope/onunhandledrejection does not exist

URL: /en-US/docs/Web/API/ServiceWorkerGlobalScope
Title: ServiceWorkerGlobalScope
on GitHub
Flaw count: 9

  • macros:
    • /en-us/docs/web/api/globalfetch (url: /en-US/docs/Web/API/GlobalFetch) does not exist
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 3 more flaws omitted

URL: /en-US/docs/Web/API/Web_Workers_API
Title: Web Workers API
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/Data_Store_API does not exist
    • /en-US/docs/Web/API/DOMRequest does not exist
    • /en-US/docs/Web/API/DOMCursor does not exist

URL: /en-US/docs/Web/API/Web_Workers_API/Functions_and_classes_available_to_workers
Title: Functions and classes available to Web Workers
on GitHub
Flaw count: 4

  • macros:
    • /en-US/docs/Web/API/Data_Store_API does not exist
    • /en-US/docs/Web/API/DOMRequest does not exist
    • /en-US/docs/Web/API/DOMCursor does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/ServiceWorker_API

URL: /en-US/docs/Glossary/Mixin
Title: Mixin
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Glossary/interface does not exist

External URLs

URL: /en-US/docs/Web/API/queueMicrotask
Title: queueMicrotask()
on GitHub


URL: /en-US/docs/Web/API/setTimeout
Title: setTimeout()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/HTML_DOM_API/Microtask_guide
Title: Using microtasks in JavaScript with queueMicrotask()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Window
Title: Window
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Cache
Title: Cache
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/WorkerGlobalScope
Title: WorkerGlobalScope
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/ServiceWorkerGlobalScope
Title: ServiceWorkerGlobalScope
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Web_Workers_API
Title: Web Workers API
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Web_Workers_API/Functions_and_classes_available_to_workers
Title: Functions and classes available to Web Workers
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/script-src
Title: CSP: script-src
on GitHub

No new external URLs


URL: /en-US/docs/Glossary/Mixin
Title: Mixin
on GitHub

No new external URLs

@teoli2003
Copy link
Contributor

teoli2003 commented Sep 10, 2021

I have a few questions:

  1. After this PR we will still have mentions of WindowOrWorkerGlobalScope in links like:
files/en-us/web/http/headers/content-security-policy/script-src/index.html
169:   <li>{{domxref("WindowOrWorkerGlobalScope.setTimeout")}}</li>
170:   <li>{{domxref("WindowOrWorkerGlobalScope.setInterval")}}</li>

Do you think we should fix these in this PR?
(I think these are the only ones, but I have not checked old mixins like WindowTimers or WindowBase64 that predate WindowOrWorkerGlobalScope)

  1. InterfaceData.json (now in mdn/content) should be fixed too.
  2. Not for this PR, but what sidebar do we want for the now top-level setTimeout(), setInterval(), origin, etc?

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my previous comment.

@Elchi3
Copy link
Member Author

Elchi3 commented Sep 10, 2021

Did you see this PR has two commits? The second fixes links and interfaceData.

@teoli2003
Copy link
Contributor

Strange. I looked at the "Files Changed" tab and the files of the 2nd commit didn't appear there. They do now. Weird.

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants