Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(css)!: Remove IE-only features #911

Closed
wants to merge 2 commits into from
Closed

chore(css)!: Remove IE-only features #911

wants to merge 2 commits into from

Conversation

skyclouds2001
Copy link
Contributor

Description

see #837 for proposal

Motivation

Additional details

Related issues and pull requests

Fixes #837
Fixes #316

@skyclouds2001 skyclouds2001 marked this pull request as ready for review January 25, 2025 07:54
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner January 25, 2025 07:54
@skyclouds2001 skyclouds2001 requested review from bsmth and removed request for a team January 25, 2025 07:54
@skyclouds2001
Copy link
Contributor Author

this could be a breaking change, so this could be defered to next version

@bsmth
Copy link
Member

bsmth commented Feb 3, 2025

this could be a breaking change, so this could be defered to next version

https://github.com/googleapis/release-please?tab=readme-ov-file#how-should-i-write-my-commits

PR title should be

chore(css)!: Remove IE-only features

@bsmth bsmth changed the title chore(css): Remove IE-only features chore(css)!: Remove IE-only features Feb 3, 2025
@skyclouds2001 skyclouds2001 marked this pull request as draft February 6, 2025 18:00
bsmth
bsmth requested changes Feb 18, 2025
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can close this for now, more information in the proposal issue. Thanks a lot for the effort, though 🙏🏻

@skyclouds2001
Copy link
Contributor Author

I think we can close this for now, more information in the proposal issue. Thanks a lot for the effort, though 🙏🏻

OK

Let's close it but leave the issue open, though

@skyclouds2001 skyclouds2001 deleted the remove-ie branch February 18, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: Remove IE-only features Missing -ms-grid-* properties
2 participants
@skyclouds2001 @bsmth