From 40925f4fd4ddda18f7fb529df5e7c462a79f99c5 Mon Sep 17 00:00:00 2001 From: Claas Augner Date: Mon, 30 Sep 2024 11:13:42 +0200 Subject: [PATCH 1/2] enhance(seo): link technologies in homepage hero --- client/src/homepage/homepage-hero/index.tsx | 28 +++++++++++++++++++-- client/src/telemetry/constants.ts | 1 + 2 files changed, 27 insertions(+), 2 deletions(-) diff --git a/client/src/homepage/homepage-hero/index.tsx b/client/src/homepage/homepage-hero/index.tsx index 6f9b47524d55..9ab6952383d2 100644 --- a/client/src/homepage/homepage-hero/index.tsx +++ b/client/src/homepage/homepage-hero/index.tsx @@ -1,8 +1,12 @@ import "./index.scss"; import { Search } from "../../ui/molecules/search"; import Mandala from "../../ui/molecules/mandala"; +import { useLocale } from "../../hooks"; +import { HOMEPAGE_HERO } from "../../telemetry/constants"; export function HomepageHero() { + const locale = useLocale(); + return (
@@ -11,8 +15,28 @@ export function HomepageHero() {
by Developers

- Documenting web technologies, including CSS, HTML, and JavaScript, - since 2005. + Documenting web technologies, including{" "} + + CSS + + ,{" "} + + HTML + + , and{" "} + + JavaScript + + , since 2005.

diff --git a/client/src/telemetry/constants.ts b/client/src/telemetry/constants.ts index cf6f586363fd..89c8ee0ce0b9 100644 --- a/client/src/telemetry/constants.ts +++ b/client/src/telemetry/constants.ts @@ -85,3 +85,4 @@ export const LANGUAGE = "language"; export const LANGUAGE_REMEMBER = "language_remember"; export const THEME_SWITCHER = "theme_switcher"; export const SURVEY = "survey"; +export const HOMEPAGE_HERO = "homepage_hero"; From 1b5842bbf9ef40bd30155d9d9f2b7b2171857488 Mon Sep 17 00:00:00 2001 From: Claas Augner Date: Mon, 30 Sep 2024 11:16:12 +0200 Subject: [PATCH 2/2] enhance(homepage): generalize link underline on hover Also, don't underline on focus, as focus already has an outline. --- client/src/homepage/featured-articles/index.scss | 5 ----- client/src/homepage/index.scss | 4 ++++ client/src/homepage/recent-contributions/index.scss | 1 - 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/client/src/homepage/featured-articles/index.scss b/client/src/homepage/featured-articles/index.scss index 6261cfeffaf6..4e9213f7f616 100644 --- a/client/src/homepage/featured-articles/index.scss +++ b/client/src/homepage/featured-articles/index.scss @@ -56,11 +56,6 @@ a { color: var(--text-primary); - - &:hover, - &:focus { - text-decoration: underline; - } } } diff --git a/client/src/homepage/index.scss b/client/src/homepage/index.scss index 33a05cb0dffb..0fedc3903eae 100644 --- a/client/src/homepage/index.scss +++ b/client/src/homepage/index.scss @@ -17,4 +17,8 @@ > *:first-child { margin-top: 0; } + + a:hover { + text-decoration: underline; + } } diff --git a/client/src/homepage/recent-contributions/index.scss b/client/src/homepage/recent-contributions/index.scss index 67b8a6bc6986..6473bc67baa0 100644 --- a/client/src/homepage/recent-contributions/index.scss +++ b/client/src/homepage/recent-contributions/index.scss @@ -57,7 +57,6 @@ &:hover { color: var(--text-primary); - text-decoration: underline; } }