From fc3a9bb8f3b3348cdeea5a5ee14d8e194c9d59b0 Mon Sep 17 00:00:00 2001 From: Eytan Adler Date: Mon, 19 Jun 2023 13:14:44 -0400 Subject: [PATCH 1/9] Update GHA checkout version --- .github/workflows/openconcept.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/openconcept.yaml b/.github/workflows/openconcept.yaml index 1477b73c..6ee72921 100644 --- a/.github/workflows/openconcept.yaml +++ b/.github/workflows/openconcept.yaml @@ -35,7 +35,7 @@ jobs: run: shell: bash -l {0} steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Setup Python ${{ matrix.PYTHON_VERSION_OLDEST }} if: ${{ matrix.dep-versions == 'oldest' }} uses: conda-incubator/setup-miniconda@v2 From 51689fde26ae3ef53a881b7aae90b53b0a2dc2e8 Mon Sep 17 00:00:00 2001 From: Eytan Adler Date: Mon, 19 Jun 2023 13:21:00 -0400 Subject: [PATCH 2/9] Roll back pip version for oldest tests --- .github/workflows/openconcept.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/openconcept.yaml b/.github/workflows/openconcept.yaml index 6ee72921..c8da858f 100644 --- a/.github/workflows/openconcept.yaml +++ b/.github/workflows/openconcept.yaml @@ -25,6 +25,7 @@ jobs: # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Set versions to test here ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PYTHON_VERSION_OLDEST: ['3.8'] PYTHON_VERSION_LATEST: ['3.11'] + PIP_VERSION_OLDEST: ['23.0.1'] # pip>=23.1 cannot build the oldest OpenMDAO NUMPY_VERSION_OLDEST: ['1.20'] # latest is most recent on PyPI SCIPY_VERSION_OLDEST: ['1.6.0'] # latest is most recent on PyPI OPENMDAO_VERSION_OLDEST: ['3.10'] # latest is most recent on PyPI @@ -53,6 +54,7 @@ jobs: if: ${{ matrix.dep-versions == 'oldest' }} run: | conda config --set always_yes yes + pip install pip==${{ matrix.PIP_VERSION_OLDEST }} --upgrade wheel pip install numpy==${{ matrix.NUMPY_VERSION_OLDEST }} scipy==${{ matrix.SCIPY_VERSION_OLDEST }} openmdao==${{ matrix.OPENMDAO_VERSION_OLDEST }} - name: Install dependencies (latest versions) if: ${{ matrix.dep-versions == 'latest' }} From 14df0369b006e17be2adb7ce5814eef2044042bb Mon Sep 17 00:00:00 2001 From: Eytan Adler Date: Mon, 19 Jun 2023 13:41:40 -0400 Subject: [PATCH 3/9] Fix pip upgrade in GHA --- .github/workflows/openconcept.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/openconcept.yaml b/.github/workflows/openconcept.yaml index c8da858f..c644919f 100644 --- a/.github/workflows/openconcept.yaml +++ b/.github/workflows/openconcept.yaml @@ -54,7 +54,8 @@ jobs: if: ${{ matrix.dep-versions == 'oldest' }} run: | conda config --set always_yes yes - pip install pip==${{ matrix.PIP_VERSION_OLDEST }} --upgrade wheel + which python + python -m pip install pip==${{ matrix.PIP_VERSION_OLDEST }} --upgrade wheel pip install numpy==${{ matrix.NUMPY_VERSION_OLDEST }} scipy==${{ matrix.SCIPY_VERSION_OLDEST }} openmdao==${{ matrix.OPENMDAO_VERSION_OLDEST }} - name: Install dependencies (latest versions) if: ${{ matrix.dep-versions == 'latest' }} From 098dc2d5fbb9aa1650d0561ff7fb5e72e584fb6c Mon Sep 17 00:00:00 2001 From: Eytan Adler Date: Mon, 19 Jun 2023 14:09:25 -0400 Subject: [PATCH 4/9] Trying older setuptools --- .github/workflows/openconcept.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/openconcept.yaml b/.github/workflows/openconcept.yaml index c644919f..9b6c5036 100644 --- a/.github/workflows/openconcept.yaml +++ b/.github/workflows/openconcept.yaml @@ -26,6 +26,7 @@ jobs: PYTHON_VERSION_OLDEST: ['3.8'] PYTHON_VERSION_LATEST: ['3.11'] PIP_VERSION_OLDEST: ['23.0.1'] # pip>=23.1 cannot build the oldest OpenMDAO + SETUPTOOLS_VERSION_OLDEST: ['66.0.0'] # setuptools >= 67.0.0 can't build the oldest OpenMDAO NUMPY_VERSION_OLDEST: ['1.20'] # latest is most recent on PyPI SCIPY_VERSION_OLDEST: ['1.6.0'] # latest is most recent on PyPI OPENMDAO_VERSION_OLDEST: ['3.10'] # latest is most recent on PyPI @@ -55,7 +56,7 @@ jobs: run: | conda config --set always_yes yes which python - python -m pip install pip==${{ matrix.PIP_VERSION_OLDEST }} --upgrade wheel + python -m pip install pip==${{ matrix.PIP_VERSION_OLDEST }} setuptools==${{ matrix.SETUPTOOLS_VERSION_OLDEST }} --upgrade wheel pip install numpy==${{ matrix.NUMPY_VERSION_OLDEST }} scipy==${{ matrix.SCIPY_VERSION_OLDEST }} openmdao==${{ matrix.OPENMDAO_VERSION_OLDEST }} - name: Install dependencies (latest versions) if: ${{ matrix.dep-versions == 'latest' }} From 29985764bce6d65ee71b6e9607406ab00ff25a24 Mon Sep 17 00:00:00 2001 From: Eytan Adler Date: Mon, 19 Jun 2023 14:11:21 -0400 Subject: [PATCH 5/9] Try getting rid of pinned pip version in oldest build --- .github/workflows/openconcept.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/openconcept.yaml b/.github/workflows/openconcept.yaml index 9b6c5036..29ff7dfa 100644 --- a/.github/workflows/openconcept.yaml +++ b/.github/workflows/openconcept.yaml @@ -56,7 +56,7 @@ jobs: run: | conda config --set always_yes yes which python - python -m pip install pip==${{ matrix.PIP_VERSION_OLDEST }} setuptools==${{ matrix.SETUPTOOLS_VERSION_OLDEST }} --upgrade wheel + python -m pip install setuptools==${{ matrix.SETUPTOOLS_VERSION_OLDEST }} --upgrade wheel pip install numpy==${{ matrix.NUMPY_VERSION_OLDEST }} scipy==${{ matrix.SCIPY_VERSION_OLDEST }} openmdao==${{ matrix.OPENMDAO_VERSION_OLDEST }} - name: Install dependencies (latest versions) if: ${{ matrix.dep-versions == 'latest' }} From c184a082b49e70778fe292715883ccbdd5cbc931 Mon Sep 17 00:00:00 2001 From: Eytan Adler Date: Mon, 19 Jun 2023 14:13:11 -0400 Subject: [PATCH 6/9] Pinned pip version is necessary --- .github/workflows/openconcept.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/openconcept.yaml b/.github/workflows/openconcept.yaml index 29ff7dfa..9b6c5036 100644 --- a/.github/workflows/openconcept.yaml +++ b/.github/workflows/openconcept.yaml @@ -56,7 +56,7 @@ jobs: run: | conda config --set always_yes yes which python - python -m pip install setuptools==${{ matrix.SETUPTOOLS_VERSION_OLDEST }} --upgrade wheel + python -m pip install pip==${{ matrix.PIP_VERSION_OLDEST }} setuptools==${{ matrix.SETUPTOOLS_VERSION_OLDEST }} --upgrade wheel pip install numpy==${{ matrix.NUMPY_VERSION_OLDEST }} scipy==${{ matrix.SCIPY_VERSION_OLDEST }} openmdao==${{ matrix.OPENMDAO_VERSION_OLDEST }} - name: Install dependencies (latest versions) if: ${{ matrix.dep-versions == 'latest' }} From b59c79149871e1b657902389a1ce01d95d8cca20 Mon Sep 17 00:00:00 2001 From: Eytan Adler Date: Mon, 19 Jun 2023 14:19:44 -0400 Subject: [PATCH 7/9] Remove which python debug in GHA --- .github/workflows/openconcept.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/openconcept.yaml b/.github/workflows/openconcept.yaml index 9b6c5036..c36622fc 100644 --- a/.github/workflows/openconcept.yaml +++ b/.github/workflows/openconcept.yaml @@ -55,7 +55,6 @@ jobs: if: ${{ matrix.dep-versions == 'oldest' }} run: | conda config --set always_yes yes - which python python -m pip install pip==${{ matrix.PIP_VERSION_OLDEST }} setuptools==${{ matrix.SETUPTOOLS_VERSION_OLDEST }} --upgrade wheel pip install numpy==${{ matrix.NUMPY_VERSION_OLDEST }} scipy==${{ matrix.SCIPY_VERSION_OLDEST }} openmdao==${{ matrix.OPENMDAO_VERSION_OLDEST }} - name: Install dependencies (latest versions) From 29a4549b104d70cdd44978a7d5d89428b9f87e78 Mon Sep 17 00:00:00 2001 From: Eytan Adler Date: Mon, 19 Jun 2023 19:56:05 -0400 Subject: [PATCH 8/9] Trying old wheel instead of pip and setuptools --- .github/workflows/openconcept.yaml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/openconcept.yaml b/.github/workflows/openconcept.yaml index c36622fc..7528e39f 100644 --- a/.github/workflows/openconcept.yaml +++ b/.github/workflows/openconcept.yaml @@ -25,8 +25,7 @@ jobs: # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Set versions to test here ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PYTHON_VERSION_OLDEST: ['3.8'] PYTHON_VERSION_LATEST: ['3.11'] - PIP_VERSION_OLDEST: ['23.0.1'] # pip>=23.1 cannot build the oldest OpenMDAO - SETUPTOOLS_VERSION_OLDEST: ['66.0.0'] # setuptools >= 67.0.0 can't build the oldest OpenMDAO + WHEEL_VERSION_OLDEST: ['0.38.4'] # latest wheel cannot build the oldest OpenMDAO (3.17 or older) NUMPY_VERSION_OLDEST: ['1.20'] # latest is most recent on PyPI SCIPY_VERSION_OLDEST: ['1.6.0'] # latest is most recent on PyPI OPENMDAO_VERSION_OLDEST: ['3.10'] # latest is most recent on PyPI @@ -55,7 +54,7 @@ jobs: if: ${{ matrix.dep-versions == 'oldest' }} run: | conda config --set always_yes yes - python -m pip install pip==${{ matrix.PIP_VERSION_OLDEST }} setuptools==${{ matrix.SETUPTOOLS_VERSION_OLDEST }} --upgrade wheel + python -m pip install wheel==${{ matrix.WHEEL_VERSION_OLDEST }} pip install numpy==${{ matrix.NUMPY_VERSION_OLDEST }} scipy==${{ matrix.SCIPY_VERSION_OLDEST }} openmdao==${{ matrix.OPENMDAO_VERSION_OLDEST }} - name: Install dependencies (latest versions) if: ${{ matrix.dep-versions == 'latest' }} From c61bfc0813a3f6f6df86bda718f01771239713e8 Mon Sep 17 00:00:00 2001 From: Eytan Adler Date: Mon, 19 Jun 2023 20:14:47 -0400 Subject: [PATCH 9/9] No bueno --- .github/workflows/openconcept.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/openconcept.yaml b/.github/workflows/openconcept.yaml index 7528e39f..c36622fc 100644 --- a/.github/workflows/openconcept.yaml +++ b/.github/workflows/openconcept.yaml @@ -25,7 +25,8 @@ jobs: # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Set versions to test here ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PYTHON_VERSION_OLDEST: ['3.8'] PYTHON_VERSION_LATEST: ['3.11'] - WHEEL_VERSION_OLDEST: ['0.38.4'] # latest wheel cannot build the oldest OpenMDAO (3.17 or older) + PIP_VERSION_OLDEST: ['23.0.1'] # pip>=23.1 cannot build the oldest OpenMDAO + SETUPTOOLS_VERSION_OLDEST: ['66.0.0'] # setuptools >= 67.0.0 can't build the oldest OpenMDAO NUMPY_VERSION_OLDEST: ['1.20'] # latest is most recent on PyPI SCIPY_VERSION_OLDEST: ['1.6.0'] # latest is most recent on PyPI OPENMDAO_VERSION_OLDEST: ['3.10'] # latest is most recent on PyPI @@ -54,7 +55,7 @@ jobs: if: ${{ matrix.dep-versions == 'oldest' }} run: | conda config --set always_yes yes - python -m pip install wheel==${{ matrix.WHEEL_VERSION_OLDEST }} + python -m pip install pip==${{ matrix.PIP_VERSION_OLDEST }} setuptools==${{ matrix.SETUPTOOLS_VERSION_OLDEST }} --upgrade wheel pip install numpy==${{ matrix.NUMPY_VERSION_OLDEST }} scipy==${{ matrix.SCIPY_VERSION_OLDEST }} openmdao==${{ matrix.OPENMDAO_VERSION_OLDEST }} - name: Install dependencies (latest versions) if: ${{ matrix.dep-versions == 'latest' }}