Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axios dependency #25

Open
Coobaha opened this issue Jan 8, 2020 · 2 comments
Open

Axios dependency #25

Coobaha opened this issue Jan 8, 2020 · 2 comments

Comments

@Coobaha
Copy link
Collaborator

Coobaha commented Jan 8, 2020

hi @meafmira,

I think axios should be moved to peerDependencies. Especially since it is not used in generated files

redacted output of yarn why axios

yarn why v1.21.1
[1/4] 🤔  Why do we have the module "axios"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "axios@0.19.1"
info Has been hoisted to "axios"
info Reasons this module exists
   - "workspace-aggregator-43088911-9698-4e6f-aaa9-6d34f43842d4" depends on it
info Disk size without dependencies: "488KB"
info Disk size with unique dependencies: "656KB"
info Disk size with transitive dependencies: "804KB"
info Number of shared dependencies: 3
=> Found "bs-axios#axios@0.18.1"
info This module exists because "bs-axios" depends on it.
info Disk size without dependencies: "412KB"
info Disk size with unique dependencies: "604KB"
info Disk size with transitive dependencies: "752KB"
info Number of shared dependencies: 4
✨  Done in 0.95s.
@hoijui
Copy link
Collaborator

hoijui commented Jul 10, 2024

@meafmira , could you maybe add additional owners to this repo, so we have a chance to maintain this?
There are projects that depend on this, and because of old deps of this project, those projects can not be maintained either.

I recommend adding the people of the issues:

optionally also me (@hoijui), though I am not a node/JS dev.

really, there is nothing to be lost, because as it is now, it is unusable (in modern software).

have a good day!

@meafmira
Copy link
Owner

Hey @hoijui 👋
Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants