Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update font-awesome and remove appcache patch #4115

Closed
garethbowen opened this issue Jan 23, 2018 · 1 comment
Closed

Update font-awesome and remove appcache patch #4115

garethbowen opened this issue Jan 23, 2018 · 1 comment
Labels
Won't fix: Deprioritized Too low priority

Comments

@garethbowen
Copy link
Member

Font Awesome has just release a new major version with various improvements but backwards incompatibilities. If the improvements are transparent to the user this should be done as part of 3.0.0, however if the icons change noticeably this should be postponed until we make other UI changes in 3.1.0.

Follow this guide to upgrade to v5 and remove the appcache compatibility patch that should be fixed as part of this issue.
@garethbowen garethbowen added Status: 1 - Triaged Type: Technical issue Improve something that users won't notice Priority: 2 - Medium Normal priority labels Jan 23, 2018
@garethbowen garethbowen self-assigned this Apr 8, 2018
@garethbowen
Copy link
Member Author

In retrospect I think it's better to delay this. It only saves us a small hotfix to the library and we're planning to migrate to a custom icon set soon anyway.

@garethbowen garethbowen added Won't fix: Deprioritized Too low priority and removed Priority: 2 - Medium Normal priority Status: 1 - Triaged Type: Technical issue Improve something that users won't notice labels May 8, 2018
@garethbowen garethbowen removed their assignment May 8, 2018
alxndrsn pushed a commit that referenced this issue Jun 27, 2018
@abbyad @alxndrsn
Updated delivery form in Standard
d0d8bfd 
Related to #3825 and #4115
alxndrsn pushed a commit that referenced this issue Jun 28, 2018
@abbyad @alxndrsn
Updated delivery form in Standard
1d8c8c3 
Related to #3825 and #4115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Won't fix: Deprioritized Too low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@garethbowen