-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build esm/cjs; fix jest #1
base: main
Are you sure you want to change the base?
Conversation
@murillo128 @mildsunrise ready for review |
@mildsunrise rebased. Please let me know if you'll consider merging this. |
hi, thanks for the PR and sorry for the delay in responding to this... it was something I was looking forward to merge but always had more important things in my desk. let me see if I can bring these changes in, especially the buildsystem ones, it'd be nice to ship a cjs version |
|
||
"module": "ES6", | ||
"target": "es2020", | ||
"lib": ["es2015", "es2016", "es2017", "es2018", "es2019", "es2020", "DOM"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do need the DOM library, at the very least for the sync
directory which uses HTML5 APIs. I think it could be dropped for everything outside it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah I see it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now I've removed the library from tsconfig, and instead used /// <reference lib="dom" />
in sync
files. not good but better than nothing
I still have to merge some stuff, like windows support, but I think it's good enough for a v1 release. Package is up on NPM, let me know if there's any issues :) |
Looks good! |
No description provided.