Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some packages #87

Merged
merged 1 commit into from
Aug 25, 2015
Merged

Update some packages #87

merged 1 commit into from
Aug 25, 2015

Conversation

bezumkin
Copy link
Contributor

  1. It seems that lessphp is officially dead - it even can`t compile Bootstrap 3! So i suggest you to replace it to oyejorge/less.php. We already use it in MODX component MinifyX and it works great!
  2. Version 6.0.0 of sabberworm/php-css-parser fails on PHP 5.3.3, so i changed it to dev-master.

@meenie
Copy link
Owner

meenie commented Aug 22, 2015

@bezumkin: If you are updating the less php library, you need to update the code that does the compiling. That is found here: https://github.com/meenie/munee/blob/master/src/Munee/Asset/Type/Css.php

@bezumkin
Copy link
Contributor Author

It seems that oyejorge/less.php replaces leafo/lessphp and provides similar class.

I have no errors for now and nobody create issues about it in MinifyX. We use oyejorge/less.php with munee more than year

@bezumkin bezumkin changed the title Uodate some packages Update some packages Aug 22, 2015
@meenie
Copy link
Owner

meenie commented Aug 22, 2015

Oops! I should have looked at it closer ><. Sorry about that :).

As for pointing to dev-master, I would rather not do that. I've put in a request for him to tag his current master to 6.0.1: MyIntervals/PHP-CSS-Parser#95

So If you don't mind, can we please wait until he does that? If it's more than a couple of days, I'll ping him again.

Thanks for your PR :).

@bezumkin
Copy link
Contributor Author

So If you don't mind, can we please wait until he does that?

Yes, of course! Thanks!

@meenie
Copy link
Owner

meenie commented Aug 24, 2015

@bezumkin, PHP-CSS-Parser has been tagged with 7.0.0 :). Please update your PR and we'll get it merged/released.

@meenie
Copy link
Owner

meenie commented Aug 24, 2015

Also, please remove the ~ from the version numbers and lock them down to their exact values.

@bezumkin
Copy link
Contributor Author

It seems that i do not understand something, but if I change sabberworm to 6.0.1 or 7.0.0 - it do not work

But 6.0.0 works good. And if i set version to "*" - 6.0.0 downloaded. Maybe it some GitHub repository cache?

@meenie
Copy link
Owner

meenie commented Aug 24, 2015

Hi @bezumkin, try running php ./composer.phar install (instead of update) after changing the composer.json file.

@bezumkin
Copy link
Contributor Author

Nope. Install does not work too.

Update worked for me always, and it work now for oyejorge/less.php. Trouble is only with sabberworm/PHP-CSS-Parser more than 6.0.0

Could you please try it yourself?

@meenie
Copy link
Owner

meenie commented Aug 24, 2015

@bezumkin: The issue is Packagist hasn't pulled in his latest tag. I've pinged him on it and hopefully it will be resolved soon :). https://packagist.org/packages/sabberworm/php-css-parser

@meenie
Copy link
Owner

meenie commented Aug 24, 2015

@bezumkin: See his update here: MyIntervals/PHP-CSS-Parser#95 (comment)

@meenie
Copy link
Owner

meenie commented Aug 25, 2015

@bezumkin: Looks like the 7.0.0 is now public in Packagist, please give it a try again.

@bezumkin
Copy link
Contributor Author

Done!

meenie added a commit that referenced this pull request Aug 25, 2015
@meenie meenie merged commit e6896ab into meenie:master Aug 25, 2015
@meenie
Copy link
Owner

meenie commented Aug 25, 2015

@bezumkin
Copy link
Contributor Author

Cool, thanks!

@bezumkin bezumkin deleted the patch-3 branch August 25, 2015 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants