Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Bad preview performance when editing page elements or properties #402

Closed
TheReincarnator opened this issue Apr 25, 2018 · 2 comments
Closed

Comments

@TheReincarnator
Copy link
Contributor

TheReincarnator commented Apr 25, 2018

Since commit 947f271 (last-changed date and author, #176 page overview), the preview performance is bad when editing page elements or properties.

The reason is that each change touches the current project, and the current granularity of IPC events triggers a full styleguide reload on the preview side (patterns scan and projects/page-refs deserialization).

Since the change does not affect the patterns path (nor the patterns themselves), the IPC messages should be split into 1. patterns path and analyzer name, 2. projects.

Alternatively, the IPC event should not trigger a patterns reload as the path nor the analyzer changes.

Note: Development on this issue is paused until #389 is merged to reduce conflicts.

@TheReincarnator
Copy link
Contributor Author

@marionebl says it will be fixed by #389 as well.

@marionebl
Copy link
Contributor

Fixed via #389 ❤️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants