This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
feat: show error on unreadable .alva files #542
Merged
+3,233
−3,137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilmx
changed the title
tilmx
changed the title
marionebl
reviewed
Jun 10, 2018
src/electron/main.ts
Outdated
| @@ -91,7 +91,10 @@ const userStore = new ElectronStore(); | |||
| const result = await Persistence.read<Types.SavedProject>(pathToOpen); | |||
|
|
|||
| if (result.state === PersistenceState.Error) { | |||
| // TODO: Show user facing error here | |||
| dialog.showErrorBox( | |||
| 'We run into a problem!', | |||
|
Fixed the typo @marionebl! |
marionebl
reviewed
Jun 10, 2018
src/electron/main.ts
Outdated
| // TODO: Show user facing error here | ||
| dialog.showErrorBox( | ||
| 'We ran into a problem!', | ||
| 'Sorry, we had trouble while opening that file. It may help to update your version of Alva.' |
There was a problem hiding this comment.
Let's change to Sorry, we had trouble while opening the file ${pathToOpen}. I'd discard the second part of the message because we'll be capable of detecting version mismatches in the future reliably (see #447)
tilmx
changed the title
tilmx
changed the title
marionebl
previously approved these changes
Jun 12, 2018
marionebl
approved these changes
Jun 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catches an file-opening error and lets the user know what happened.
Todo
Should be squashed into
feat: show error on unreadable .alva files