This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
feat: restore slot handling based on element contents #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really cool! Thanks for restoring that feature! I just came across three thingies:
That would be great! |
tilmx
reviewed
Jun 10, 2018
| props.element.getNameEditable(); | ||
| props.element.getHighlighted(); | ||
| props.element.acceptsChildren(); | ||
| // props.element.getSelected(); |
marionebl
force-pushed
the
feat/restore-slot-in-elements
branch
from
61c6204
to
c411db0
Compare
lkuechler
previously requested changes
Jun 12, 2018
| display: flex; | ||
| align-items: center; | ||
| color: ${Color.Grey20}; | ||
| position: relative; |
There was a problem hiding this comment.
This is a duplicate to line 60
| position: relative; | ||
| display: flex; | ||
| align-items: center; | ||
| color: ${Color.Grey20}; |
There was a problem hiding this comment.
in line 68 this is overridden
| box-sizing: border-box; | ||
| margin-left: ${getSpace(SpaceSize.XXL) - 3}px; | ||
| overflow: hidden; | ||
| padding: ${getSpace(SpaceSize.XS)}px ${getSpace(SpaceSize.XXS)}px ${getSpace(SpaceSize.XS)}px |
There was a problem hiding this comment.
this could be written shorter as padding: ${getSpace(SpaceSize.XS)}px ${getSpace(SpaceSize.XXS)}px;
src/components/element/element.tsx
Outdated
| position: relative; | ||
| display: flex; | ||
| align-items: center; | ||
| color: ${Color.Grey20}; |
There was a problem hiding this comment.
this can be removed. It is already overridden in line 96
|
@lkuechler Good spots – I removed the duplicates! |
# Conflicts: # src/components/element/demo.tsx # src/components/element/index.tsx # src/components/index.ts # src/container/element-list/element-container.tsx
tilmx
approved these changes
Jun 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tilmx: Could you improve the styling of
components/element-slot? Thanks!