Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

feat: create projects without explicit path #605

Merged
merged 4 commits into from
Sep 17, 2018

Conversation

marionebl
Copy link
Contributor

This changes the basic behavior to ask for a save path on quit / window close / save for draft projects instead of asking up front.

Draft projects are saved in the application support files when first created and marked as draft. When one of the following events occur for a draft project, the user is asked for a path to save to:

  • Cmd+S (draft projects)
  • Cmd+Shift+S (all projects)
  • Any dialog schedules a save transaction

Additionally, when trying to close a window with a draft project active the user is asked wether the current project should be saved, discarded or the close canceled.

Dialog screen shot 2018-09-14 at 22 47 40

@tilmx
Copy link
Member

tilmx commented Sep 15, 2018

@marionebl Looks great! I stumbled across just two thingies:

  • Approx a second after creating a new file, the name jumps from "New Project" to a long uuid. See attached image:

alva

  • When hitting cmd+s, Alva shows the save dialog bound on the same window (not as a separate view). but when I try to close Alva, click on the upcoming "Do you want to save?"-Dialog on "Save" – it is a separate window. Can we bind this save dialog also to the main window?

@marionebl
Copy link
Contributor Author

When hitting cmd+s, Alva shows the save dialog bound on the same window (not as a separate view). but when I try to close Alva, click on the upcoming "Do you want to save?"-Dialog on "Save" – it is a separate window. Can we bind this save dialog also to the main window?

I am pretty sure this is caused be the "Do you want to save" dialog box still being active when we init the save select dialog, causing it to detach itself from the window. Adding a timeout before triggering the save transaction might solve this, but I'd rather live with the current state.

@tilmx
Copy link
Member

tilmx commented Sep 15, 2018

I am pretty sure this is caused be the "Do you want to save" dialog box still being active when we init the save select dialog, causing it to detach itself from the window. Adding a timeout before triggering the save transaction might solve this, but I'd rather live with the current state.

Okay, let’s do that!

@marionebl
Copy link
Contributor Author

Approx a second after creating a new file, the name jumps from "New Project" to a long uuid. See attached image:

Fixed

@tilmx
Copy link
Member

tilmx commented Sep 15, 2018

@marionebl Works perfectly fine now! Thanks!

@Palmaswell Palmaswell merged commit 9612f21 into master Sep 17, 2018
@marionebl marionebl deleted the feat/pathless-projects branch September 17, 2018 09:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants