Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continuum normalization may fail for some cases #23

Open
megbedell opened this issue Jul 20, 2018 · 3 comments
Open

continuum normalization may fail for some cases #23

megbedell opened this issue Jul 20, 2018 · 3 comments

Comments

@megbedell
Copy link
Owner

Currently the sigma clipping in the continuum fitting function is very asymmetric, which @davidwhogg says is "playing with fire." We should check that this doesn't fail for other datasets.

@davidwhogg
Copy link
Collaborator

I agree.

@davidwhogg
Copy link
Collaborator

ps. We could clip hard and asymmetric, but then do a mean-rms adjustment to compensate for the asymmetry. Put this in as a homework question for me.

@megbedell megbedell added the bug label Oct 5, 2018
@megbedell megbedell added this to the run on all of HARPS milestone Oct 5, 2018
@megbedell
Copy link
Owner Author

maybe incorporate continuum fitting into the model itself with a GP and forget about initial normalization??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants