Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to nom 4 #63

Merged
merged 1 commit into from
Jul 2, 2018
Merged

update to nom 4 #63

merged 1 commit into from
Jul 2, 2018

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Feb 17, 2018

Hello,

I'm currently testing the upgrade to nom 4 on various crates, to see if I forgot anything. Currently, I get these error after doing the following changes:

[Running 'cargo test']
    Finished dev [unoptimized + debuginfo] target(s) in 0.0 secs
     Running target/debug/deps/config-a0903495d12738cd

running 5 tests
test path::parser::test::test_subscript ... ok
test path::parser::test::test_subscript_neg ... ok
test path::parser::test::test_child ... FAILED
test path::parser::test::test_id_dash ... FAILED
test path::parser::test::test_id ... FAILED

failures:

---- path::parser::test::test_child stdout ----
        thread 'path::parser::test::test_child' panicked at 'called `Result::unwrap()` on an `Err` value: Complete', libcore/result.rs:945:5

---- path::parser::test::test_id_dash stdout ----
        thread 'path::parser::test::test_id_dash' panicked at 'called `Result::unwrap()` on an `Err` value: Complete', libcore/result.rs:945:5

---- path::parser::test::test_id stdout ----
        thread 'path::parser::test::test_id' panicked at 'called `Result::unwrap()` on an `Err` value: Complete', libcore/result.rs:945:5
note: Run with `RUST_BACKTRACE=1` for a backtrace.


failures:
    path::parser::test::test_child
    path::parser::test::test_id
    path::parser::test::test_id_dash

test result: FAILED. 2 passed; 3 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '--lib'

They are probably linked to the new behaviour around partial data. It requires changing the input types, but makes all parsers easier to write.

@mehcode mehcode merged commit e3f25ce into rust-cli:master Jul 2, 2018
@mehcode
Copy link
Collaborator

mehcode commented Jul 2, 2018

Thanks @Geal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants