Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing documentation deployement #581

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Conversation

alallema
Copy link
Contributor

@alallema alallema commented Sep 19, 2023

Pull Request

Related issue

The documentation deployment is falling:

In Application.php line 725:
                                                                  
  [Symfony\Component\Console\Exception\CommandNotFoundException]  
  Command "tests/" is not defined.                                
                                                                  

Exception trace:
  at /opt/phpdoc/vendor/symfony/console/Application.php:725
 Symfony\Component\Console\Application->find() at /opt/phpdoc/vendor/symfony/console/Application.php:262
 Symfony\Component\Console\Application->doRun() at /opt/phpdoc/src/phpDocumentor/Console/Application.php:78
 phpDocumentor\Console\Application->doRun() at /opt/phpdoc/vendor/symfony/console/Application.php:174
 Symfony\Component\Console\Application->run() at /opt/phpdoc/bin/phpdoc:14

Error: Process completed with exit code 1.

See the full logs

What does this PR do?

  • This PR modifies the docker command who builds the documentation by using -d /data to specify the directory inside the container where the source code resides that data prefix makes sure we're referencing paths inside the Docker container correctly.

Notes to the reviewer:

  • To see if it was working properly I added the action on the pull request then I finally removed it. you can see the build logs here
  • The deployment hopefully is not allowed on other branch than main:
    Screenshot 2023-09-19 at 13 49 00

@alallema alallema added the skip-changelog The PR will not appear in the release changelogs label Sep 19, 2023
@alallema alallema requested a review from curquiza September 19, 2023 11:48
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!!

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Sep 19, 2023

@alallema alallema merged commit 63b277c into main Sep 19, 2023
8 checks passed
@alallema alallema deleted the fix/build-documentation branch September 19, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants