Add proximityPrecision management methods
#606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norkunas
requested changes
Jan 10, 2024
norkunas
requested changes
Jan 10, 2024
brunoocasali
force-pushed
the
proximity-precision
branch
from
0029647 to
216bafe
Compare
norkunas
approved these changes
Jan 10, 2024
curquiza
requested changes
Jan 11, 2024
3 tasks
norkunas
reviewed
Jan 15, 2024
Comment on lines
355
to
357
| /** | ||
| * @param non-empty-string $type | ||
| */ |
There was a problem hiding this comment.
also I wonder is it an enum or can be anything?
meili-bors bot
added a commit
that referenced
this pull request
Jan 15, 2024
609: Update version for the next release (v1.6.0) r=brunoocasali a=meili-bot _This PR is auto-generated._ The automated script updates the version of meilisearch-php to a new version: "v1.6.0" **CHANGELOG:** --- ## 🚀 Enhancements * Add support for the new setting: `proximityPrecision` (#606) brunoocasali ```php $client->index('books')->getProximityPrecision(); $client->index('books')->updateProximityPrecision('byAttribute'); $client->index('books')->resetProximityPrecision(); ``` ## 🧪 Experimental enhancement - Hybrid and vector search⚠️ This is about an experimental feature of Meilisearch. Activate the [`vectorStore` experimental feature to use it](https://www.meilisearch.com/docs/reference/api/experimental_features#configure-experimental-features) * Add support for the `embedders` settings & Add support for the `hybrid` parameter during search (#608) brunoocasali ```js $client->index('books')->getEmbedders(); $client->index('books')->updateEmbedders(['default' => ['source' => 'userProvided', 'dimensions' => 1]]); $client->index('books')->resetEmbedders(); ``` ## ⚙️ Maintenance/misc * Declare ``@throws`` in HandlesTasks delegate (#599) `@norkunas` Thanks again to `@norkunas,` `@brunoocasali!` 🎉 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
3 tasks
meili-bors bot
added a commit
that referenced
this pull request
Jan 17, 2024
610: Use proper typehint for proximityPrecision r=curquiza a=norkunas # Pull Request ## Related issue Fixes #606 (comment) ## What does this PR do? - Declares proper typehint to know what values may be returned/accepted. ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Co-authored-by: Tomas <norkunas.tom@gmail.com>
meili-bors bot
added a commit
to meilisearch/meilisearch-symfony
that referenced
this pull request
Feb 16, 2024
318: Proximity precision r=norkunas a=norkunas # Pull Request ## Related issue Fixes #<issue_number> ## What does this PR do? - Adds support for proximity precision setting ## PR checklist Please check if your PR fulfills the following requirements: - [ ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? I've based this PR on #317 so will rebase if/after it is merged to get rid of the first commit and also meilisearch/meilisearch-php#606 should be merged first Co-authored-by: Tomas <norkunas.tom@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-release work for v1.6.