Add react-jsx-ppx as a separate package #396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 13, 2022
|
This happens to fix #191 |
davesnx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible for clients to remove jsx-3 and add
(preprocess (ppx melange.react-jsx-ppx))to transform[@JSX]and[@react.component].This PR adds the new ppx as a separate package and keeps the old behaviour with the "-bs-jsx" flag to have an easier transition. We would need to update the template all in once and that would mean we need the dune integration to update the templates, I believe is easier to have both options for a bit of time.
The only missing part are name and versioning. It's @anmonteiro call. The name of the package and if it will live under melange? So
melange.react-jsx-ppxorreact-jsx-ppxorreactjs-jsx-ppx. How versioning should be done, maybe a separate version might make sense, but coupling with melange versions is easier/safer. Once this is sorted, we should push it to opam.