Fix tests #121
Merged
Fix tests #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pastushenkoy
requested review from
kakkoyun,
limayekaiwalya and
seandtaber
as code owners
|
@kakkoyun Can you help me with the build? I can't get what it wants. |
|
@pastushenkoy It's totally unrelated to your changes. I have fixed the master. Please rebase and it should be all good. |
|
I'm afraid I already got the latest changes in my master branch. |
kakkoyun
reviewed
May 26, 2020
CHANGELOG.md
Outdated
| @@ -26,6 +26,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - Fixes [#88](https://github.com/meltwater/drone-cache/issues/88). | |||
| - [#86](https://github.com/meltwater/drone-cache/pull/86) Fixed rebuild errors when a nested path given in mount. | |||
| - Fixes [#87](https://github.com/meltwater/drone-cache/issues/87). | |||
| - [120](https://github.com/meltwater/drone-cache/pull/121) | |||
There was a problem hiding this comment.
I don't think we need a changelog entry for this one. Just external dependency update for tests.
|
I've forgotten to push. Now it's fixed and your branch is up-to-date. If you would address the comment then we can go ahead and merge it. Thanks a lot for fixing it 😄 |
|
Seems like it's done? ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read CONTRIBUTING.md for details on our code of conduct, and the process for submitting pull requests to us.
Fixes #120
Proposed Changes
Description
Specifies exact version of GCS mock in order to keep tests green.
Checklist
Unreleasedsection of CHANGELOG.