Preventing internal testing notifications from reaching pipeline module #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-hek
reviewed
Nov 15, 2021
lib/membrane/testing/sink.ex
Outdated
| @@ -41,6 +43,12 @@ defmodule Membrane.Testing.Sink do | |||
| """ | |||
| ] | |||
|
|
|||
| defmacrop notify(payload) do | |||
There was a problem hiding this comment.
Friday afternoon commits, I think that is the only explanation. Changed to defp
There was a problem hiding this comment.
So you can move it to the end of the module too ;)
mat-hek
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from this Pull Request will make sure that notifications sent internally by different elements of Membrane.Testing will not be reaching the pipeline specified with
moduleoptionAll notifications sent by Testing elements to Testing.Pipeline are now wrapped in
Membrane.Testing.Notificationstruct. Previous implementation made it impossible to easily differentiate between user-specified notifications and those used by Testing module and introduced risk of conflicts