Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unknown node error on distribution changes #352

Merged
merged 3 commits into from
Dec 2, 2021
Merged

fix unknown node error on distribution changes #352

merged 3 commits into from
Dec 2, 2021

Conversation

mat-hek
Copy link
Member

@mat-hek mat-hek commented Nov 18, 2021

closes #346
cc @ostinelli

@mat-hek mat-hek requested review from mickel8 and andpodob November 18, 2021 13:08
mickel8
mickel8 previously approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@mickel8 mickel8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we disscussed it might be worth to change bundlex behaviour so that it doesn't change node to distributed one dinamically

@mickel8 mickel8 mentioned this pull request Nov 19, 2021
Closed
andpodob
andpodob previously approved these changes Dec 2, 2021
View reviewed changes
@mat-hek @andpodob
Update lib/membrane/core/bin.ex
842e89d 
Co-authored-by: Andrzej Podobiński <andrzejpodobinski2@gmail.com>
@mat-hek mat-hek dismissed stale reviews from andpodob and mickel8 via 842e89d December 2, 2021 15:13
@andpodob andpodob self-requested a review December 2, 2021 15:40
@mat-hek mat-hek merged commit 04211e1 into master Dec 2, 2021
@mat-hek mat-hek deleted the fix-node-rc branch December 2, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andpodob andpodob andpodob approved these changes

@mickel8 mickel8 mickel8 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when starting pipeline that includes an element using C Nodes
3 participants
@mat-hek @mickel8 @andpodob