Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed PadAdded spec #359

Merged
merged 3 commits into from
Dec 7, 2021
Merged

Fixed PadAdded spec #359

merged 3 commits into from
Dec 7, 2021

Conversation

Qizot
Copy link
Member

@Qizot Qizot commented Dec 7, 2021

It happens that the type spec for PadAdded context which is passed with handle_pad_add callback is outdated and is suggesting that pad options will be a keyword list where in fact it is using PadData options which is a map. The data is extracted here.

@Qizot Qizot requested a review from mat-hek December 7, 2021 11:39
mat-hek
mat-hek previously approved these changes Dec 7, 2021
View reviewed changes
@Qizot Qizot requested a review from mat-hek December 7, 2021 12:27
@Qizot Qizot merged commit 3ebe82b into master Dec 7, 2021
@Qizot Qizot deleted the fix-pad-added-callback-spec branch December 7, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mat-hek mat-hek mat-hek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Qizot @mat-hek