Time conversion for rationals #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varsill
added
the
no-changelog
…d always explicitly call functions from Ratio module. Add tests checking the added functionality.Make credo happy ;)
…tions into round_to_<units>/1. Update the rest of code accordingly to that change
varsill
removed
the
no-changelog
mat-hek
reviewed
Jul 11, 2022
…mbraneframework/membrane_core into time_conversion_for_rationals
mat-hek
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces function to convert desired number of time units (
seconds,hoursetc.) represented as a%Ratiostructure.