Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mock resource guard #478

Merged
merged 2 commits into from
Nov 17, 2022
Merged

mock resource guard #478

merged 2 commits into from
Nov 17, 2022

Conversation

mat-hek
Copy link
Member

@mat-hek mat-hek commented Nov 17, 2022

No description provided.

FelonEkonom
FelonEkonom requested changes Nov 17, 2022
View reviewed changes
lib/membrane/testing/assertions.ex Outdated
) do
assert_receive_from_resource_guard(
mock_guard,
{:cleanup, tag},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{:cleanup, tag},
{:unregister, tag},

lib/membrane/testing/mock_resource_guard.ex
Comment on lines +65 to +68
defp ex_unit_start_supervised(child_spec) do
# It's not a 'normal' call to keep dialyzer quiet
apply(ExUnit.Callbacks, :start_supervised, [child_spec])
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@mat-hek mat-hek merged commit db38a38 into master Nov 17, 2022
@mat-hek mat-hek deleted the mock-resouce-guard branch November 17, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelonEkonom FelonEkonom FelonEkonom approved these changes

@varsill varsill varsill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mat-hek @varsill @FelonEkonom