Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mage Node2Vec update after bumping Gensim version #967

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

imilinovic
Copy link
Contributor

@imilinovic imilinovic commented Aug 9, 2024

Description

Bumping Gensim version from 4.0.0 to 4.3.3 which is used in Node2Vec changed some default values which needed to be updated.

Pull request type

Please check what kind of PR this is:

  • Fix or improvement of an existing page
  • New documentation page, release related

Related PRs and issues

PR this doc page is related to:
MAGE/PR502

Closes:
(paste the link to the issue it closes)

Checklist:

  • Check all content with Grammarly
  • Perform a self-review of my code
  • Make corresponding changes to the rest of the documentation (consult with the DX team)
  • The build passes locally
  • My changes generate no new warnings or errors
  • Add a corresponding label
  • If release-related, add a product and version label
  • If release-related, add release note on product PR

Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 7:03am

@imilinovic imilinovic changed the title Node2vec Node2vec update Aug 9, 2024
@imilinovic imilinovic changed the title Node2vec update Mage Node2Vec update after bumping Gensim version Aug 9, 2024
@imilinovic imilinovic self-assigned this Aug 9, 2024
@imilinovic imilinovic marked this pull request as ready for review August 9, 2024 09:45
Copy link
Contributor

@kgolubic kgolubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks OK.

@kgolubic kgolubic added status: ready PR is ready for review future release For one of the next versions labels Aug 12, 2024
@@ -118,10 +118,10 @@ The procedure returns calculated embeddings and the corresponding list of embedd
training progresses.
- `sg : {0, 1}` ➡ Training algorithm: 1 for skip-gram; otherwise CBOW.
- `hs : {0, 1}` ➡ If 1, hierarchical softmax will be used for model training. If
0, and `negative` is non-zero, negative sampling will be used.
0, and `negative` is positive, negative sampling will be used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"negative is positive" is very confusing. Please find a more clear way to express the idea.

@kgolubic kgolubic merged commit 5cd1951 into memgraph-2-19 Aug 14, 2024
2 checks passed
@kgolubic kgolubic deleted the node2vec-update branch August 14, 2024 11:49
kgolubic added a commit that referenced this pull request Aug 14, 2024
* Update README.md

* Added description for hiding sensitive information under database-man… (#873)

* Docs improvements (#799)

* Add NuRaft log file flag (#816)

* Add health checks docs (#833)

* Update HA examples

* Add NuRaft log file env (#848)

* Add leader/follower role (#857)

Co-authored-by: Antonio Filipovic <61245998+antoniofilipovic@users.noreply.github.com>

* Add coordinator hostname HA configuration option (#860)

* First leader

* Update pages/clustering/high-availability.mdx

Co-authored-by: Katarina Supe <61758502+katarinasupe@users.noreply.github.com>

---------

Co-authored-by: Kruno Golubic <46486712+kgolubic@users.noreply.github.com>
Co-authored-by: Katarina Supe <61758502+katarinasupe@users.noreply.github.com>

* Add monitoring at runtime docs (#806)

* Added description for hiding sensitive information under database-managment/logs

* database-less connections update (#853)

* Update HA docs

* Added link to correct chapter

* Fixed issues pointed out in pr

* Add comments to PR review

---------

Co-authored-by: Andi <andi8647@gmail.com>
Co-authored-by: Kruno Golubic <46486712+kgolubic@users.noreply.github.com>
Co-authored-by: kgolubic <kgolubic@gmail.com>
Co-authored-by: Antonio Filipovic <61245998+antoniofilipovic@users.noreply.github.com>
Co-authored-by: Katarina Supe <61758502+katarinasupe@users.noreply.github.com>
Co-authored-by: Josipmrden <josip.mrden@memgraph.io>
Co-authored-by: andrejtonev <29177572+andrejtonev@users.noreply.github.com>
Co-authored-by: hal-eisen-MG <145572763+hal-eisen-MG@users.noreply.github.com>

* TTL docs (#913)

* TTL page

* Update pages/querying/time-to-live.mdx

* Update time-to-live.mdx

* Update menu

* Enterprise tag and timezone callout

* PR comments

---------

Co-authored-by: Kruno Golubic <46486712+kgolubic@users.noreply.github.com>
Co-authored-by: kgolubic <kgolubic@gmail.com>

* Prehashed password (#950)

* new: Add Lab 2.16 release notes and connection types docs (#965)

* new: Add Lab 2.16 release notes and connection types docs

* fix: Add links to replication and ha

* Fix errors in SSO documentation (#968)

* Update README.md

* Fix mistakes in SSO docs

* SSO documentation fix

* remove duplicate

* Grammar error

---------

Co-authored-by: kgolubic <kgolubic@gmail.com>
Co-authored-by: Kruno Golubic <46486712+kgolubic@users.noreply.github.com>

* [main < 925-fix-perdiodic-page] Move the example to the bottom of the page (#937)

* Move example

* Update periodic.mdx

* Update periodic.mdx

---------

Co-authored-by: hal-eisen-MG <145572763+hal-eisen-MG@users.noreply.github.com>

* fix: Apply changes to the Port description

---------

Co-authored-by: Ivan Milinović <44698587+imilinovic@users.noreply.github.com>
Co-authored-by: kgolubic <kgolubic@gmail.com>
Co-authored-by: Kruno Golubic <46486712+kgolubic@users.noreply.github.com>
Co-authored-by: hal-eisen-MG <145572763+hal-eisen-MG@users.noreply.github.com>

* [memgraph-2-19 < memgraph-2-19-relase-notes] Release notes for Memgraph 2.19 (#892)

* Update RN

* Update release notes

* Update release notes

* Update release notes

* Update RN

* Update RN

* Update RN

* Update RN

* Add docs for property compression (#962)

* add docs for property compression

* add suggestions

* LocalDateTime and timezone updates (#946)

* LocalDateTime and timezone updates

* PR comments

---------

Co-authored-by: Kruno Golubic <46486712+kgolubic@users.noreply.github.com>

* [Memgraph-2.19 < Helm chart updates] Add configs and notes (#960)

* Add config and enterprise note.

* Update naming.

* Update release notes

* Show active users (#963)

* Add active users info

* Correct information

* PR addressing

* PR addressing

* Storage info

* Empty line

---------

Co-authored-by: Kruno Golubic <46486712+kgolubic@users.noreply.github.com>

* Add periodic commit documentation (#935)

* Add initial commit

* Add periodic commit

* Add link

* Add link

* Add operators

* PR addressing

* Address PR

---------

Co-authored-by: Kruno Golubic <46486712+kgolubic@users.noreply.github.com>

* Update direct download links

* Mage Node2Vec update after bumping Gensim version (#967)

* update node2vec

* Wording changes

* Update sitemap

* Add Ubuntu 24.04 (#975)

* Change wording in show instances part of HA docs (#949)

* change wording in show instances part of HA docs

* fix wording2

---------

Co-authored-by: Kruno Golubic <46486712+kgolubic@users.noreply.github.com>

* Add ubuntu

* Update direct download links

* Update direct download links

---------

Co-authored-by: Antonio Filipovic <61245998+antoniofilipovic@users.noreply.github.com>

---------

Co-authored-by: tonijurjevic96 <168409767+tonijurjevic96@users.noreply.github.com>
Co-authored-by: Andi <andi8647@gmail.com>
Co-authored-by: Antonio Filipovic <61245998+antoniofilipovic@users.noreply.github.com>
Co-authored-by: Katarina Supe <61758502+katarinasupe@users.noreply.github.com>
Co-authored-by: Josipmrden <josip.mrden@memgraph.io>
Co-authored-by: andrejtonev <29177572+andrejtonev@users.noreply.github.com>
Co-authored-by: hal-eisen-MG <145572763+hal-eisen-MG@users.noreply.github.com>
Co-authored-by: Toni <toni.lastre@memgraph.io>
Co-authored-by: Ivan Milinović <44698587+imilinovic@users.noreply.github.com>
Co-authored-by: David Ivekovic <david.ivekovic@memgraph.io>
Co-authored-by: Ante Javor <ante.javor@memgraph.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future release For one of the next versions memgraph-2-19 status: ready PR is ready for review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants