-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add postgresql migration #464
Conversation
@Josipmrden, can you please update the milestone if this is going out with 1.18? Thanks! |
python/migrate.py
Outdated
postgres_dict[threading.get_native_id][Constants.CONNECTION].close() | ||
postgres_dict[threading.get_native_id][Constants.CONNECTION].commit() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you reorder these two, I think Buda correctly noticed once that we need first to commit and then close, this was bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
@kgolubic I still need to add documentation, pls remind if I don't create it |
Quality Gate passedIssues Measures |
@Josipmrden is this the docs PR? -> memgraph/documentation#770 |
I will use this as Release note:
|
Description
Postgresql migration module has been added.
Pull request type
Related issues
X
######################################
Reviewer checklist (the reviewer checks this part)
Module/Algorithm
Documentation checklist