Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postgresql migration #464

Merged
merged 10 commits into from
Jun 6, 2024
Merged

Add postgresql migration #464

merged 10 commits into from
Jun 6, 2024

Conversation

Josipmrden
Copy link
Collaborator

@Josipmrden Josipmrden commented Apr 18, 2024

Description

Postgresql migration module has been added.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

X

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Tests provided (unit / e2e)
  • Code documentation
  • README short description

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Added a migration module from Postgres to Memgraph
  • Link the documentation PR here
  • Tag someone from docs team in the comments @kgolubic

@Josipmrden Josipmrden added Docs needed Docs needed feature feature labels Apr 18, 2024
@Josipmrden Josipmrden added this to the 1.17.0 milestone Apr 18, 2024
@Josipmrden Josipmrden self-assigned this Apr 18, 2024
@kgolubic
Copy link

@Josipmrden, can you please update the milestone if this is going out with 1.18? Thanks!

@Josipmrden Josipmrden modified the milestones: 1.17.0, 1.18.0 May 28, 2024
Comment on lines 339 to 340
postgres_dict[threading.get_native_id][Constants.CONNECTION].close()
postgres_dict[threading.get_native_id][Constants.CONNECTION].commit()
Copy link
Contributor

@antoniofilipovic antoniofilipovic May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you reorder these two, I think Buda correctly noticed once that we need first to commit and then close, this was bug

Copy link
Contributor

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change

Copy link
Contributor

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@Josipmrden Josipmrden merged commit 3b674e6 into main Jun 6, 2024
8 checks passed
@Josipmrden Josipmrden deleted the postgresql-migration branch June 6, 2024 11:30
@Josipmrden
Copy link
Collaborator Author

@kgolubic I still need to add documentation, pls remind if I don't create it

Copy link

sonarcloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kgolubic
Copy link

kgolubic commented Jun 13, 2024

@Josipmrden is this the docs PR? -> memgraph/documentation#770

@kgolubic
Copy link

I will use this as Release note:

  • Added a PostgreSQL migration module to MAGE that enables direct migration from
    a PostgreSQL database to Memgraph. This new module streamlines the data import
    process by reducing the need for intermediate steps, such as using CSV files.
    Users can now migrate tables, including nodes and relationships, directly into
    Memgraph.
    #464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs needed Docs needed feature feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants