Skip to content

Commit

Permalink
Add codecov token
Browse files Browse the repository at this point in the history
  • Loading branch information
sidharthv96 committed Jul 3, 2023
1 parent 1b190b2 commit 288f512
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ jobs:
name: mermaid-codecov
fail_ci_if_error: false
verbose: true
token: 6845cc80-77ee-4e17-85a1-026cd95e0766

This comment has been minimized.

Copy link
@nirname

nirname Jul 3, 2023

Contributor

Should not we add this token to github tokens and remove from the code?

This comment has been minimized.

Copy link
@sidharthv96

sidharthv96 Jul 3, 2023

Author Member

Nope, this is ugly, but it's the only way, and the officially recommended one for codecov.
GitHub secrets won't be available in forks, causing those to fail.

- name: Upload Artifacts
uses: actions/upload-artifact@v3
if: ${{ failure() && steps.cypress.conclusion == 'failure' }}
Expand Down

0 comments on commit 288f512

Please sign in to comment.