Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalization relationship should be represented by a hollow triangle, not a solid one. #3816

Closed
hsolbrig opened this issue Nov 19, 2022 · 3 comments · Fixed by #4788
Closed
Assignees
Labels
Contributor needed Good first issue! Graph: Class Status: Approved Is ready to be worked on Type: Bug / Error Something isn't working or is incorrect

Comments

@hsolbrig
Copy link

Description

According to section 9.2.4.2 Other elements in the UML 2.5.1 Specificatiion,
A Generalization is shown as a line with a hollow triangle as an arrowhead between the symbols representing the involved Classifiers. The arrowhead points to the symbol representing the general Classifier.

The models on the Mermaid webpage are drawing them as solid.

Steps to reproduce

Draw any subclass relationship.

Screenshots

image

Code Sample

No response

Setup

Desktop

  • OS and Version: [Windows, Linux, Mac, ...]
  • Browser and Version: [Chrome, Edge, Firefox]

Smartphone

  • Device: [Samsung, iPhone, ...]
  • OS and Version: [Android, iOS, ...]
  • Browser and Version: [Chrome, Safari, ...]

Additional Context

No response

@tushar-c23
Copy link

Hi, I'm Tushar Choudhary, a computer science undergrad from India. I would like to contribute to the project and solve this issue. The codebase of the project and the issue seems to be in the purview of my knowledge.
How should i get started?

@jgreywolf jgreywolf self-assigned this Mar 17, 2023
@jgreywolf jgreywolf added Status: Approved Is ready to be worked on and removed Status: Triage Needs to be verified, categorized, etc fosshack labels Mar 17, 2023
@jgreywolf
Copy link
Contributor

@tushar-c23 Let me know if you are still interested in taking this on, and I will assign to you

@tushar-c23
Copy link

@jgreywolf Sure! I am still interested in taking this. Please guide me how to get started with this and i'll be on my way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor needed Good first issue! Graph: Class Status: Approved Is ready to be worked on Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
4 participants