-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added functionality to support style keyword #5111
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc change is mandatory. Rest are good to have.
Co-authored-by: Sidharth Vinod <sidharthv96@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5111 +/- ##
===========================================
- Coverage 79.37% 76.80% -2.58%
===========================================
Files 166 166
Lines 13878 13886 +8
Branches 705 707 +2
===========================================
- Hits 11016 10665 -351
- Misses 2710 3059 +349
- Partials 152 162 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this new feature!
The doc change is mandatory. Rest are good to have.
Also, please add a full example + screenshot to your PR description, because this feature looks beautiful, and you should show it off to other mermaid users that see this PR!
Co-authored-by: Alois Klink <alois@mermaidchart.com>
Co-authored-by: Alois Klink <alois@mermaidchart.com>
Co-authored-by: Alois Klink <alois@mermaidchart.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! We did have a failing E2E test, but I think it might just be a flaky test, so I've rerun the tests and hopefully that would fix it.
…maid-js/mermaid into 2408-support-style-for-class
Thank you, Justin! The world much appreciates your effort 👍 |
📑 Summary
This change allows users to use syntax such as:
style CLASSNAME fill:#000,stroke:2px
in order to apply css styles to individual class boxes
Resolves #2408
Example
Rendering the following Mermaid diagram will look like: