Fix TypeScript dependencies

[remcohaszing]

📑 Summary

The Mermaid type definitions depend on @types/d3 and @types/dompurify. Without these dependencies, the Mermaid types cause a type error for users.

Resolves N/A

📏 Design Decisions

I moved the dependencies from devDependencies to dependencies and ran pnpm install.

📋 Tasks

Make sure you

• 📖 have read the contribution guidelines
• 💻 have added necessary unit/e2e tests.
• 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
• 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

[changeset-bot]

🦋 Changeset detected

Latest commit: 72d60d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
mermaid	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✅ Deploy Preview for mermaid-js ready!

Name	Link
🔨 Latest commit	72d60d2
🔍 Latest deploy log	https://app.netlify.com/sites/mermaid-js/deploys/67000773aa2901000890e25d
😎 Deploy Preview	https://deploy-preview-5933--mermaid-js.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[pkg-pr-new]

Open in Stackblitz

pnpm add https://pkg.pr.new/mermaid-js/mermaid@5933

pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@5933

pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@5933

pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@5933

commit: 72d60d2

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.67%. Comparing base (ddf18dd) to head (72d60d2).
Report is 11 commits behind head on develop.

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #5933      +/-   ##
==========================================
- Coverage     4.67%   4.67%   -0.01%     
==========================================
  Files          372     373       +1     
  Lines        51669   51680      +11     
  Branches       611     586      -25     
==========================================
  Hits          2414    2414              
- Misses       49255   49266      +11     

Flag	Coverage Δ
unit	4.67% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

[argos-ci]

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
default (Inspect)	✅ No changes detected	-	Oct 4, 2024, 3:42 PM

[sidharthv96]

Is there a better way for us to handle this? Adding @types to dependencies seems counterintuitive. Perhaps bundling the required types, or something else?

[remcohaszing]

Why is it counterintuitive to you? A lot of packages have dependencies purely for their types. Especially a dependency on @types/x is common if you depend on x.

[sidharthv96]

My mental model was dependencies only need runtime libraries. But that's not true for libraries. Thank you!

microsoft/types-publisher#81 (comment)