Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useMaxWidth to flowRenderer #964

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Conversation

volkanunsal
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1009

  • 0 of 7 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.492%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/diagrams/flowchart/flowRenderer.js 0 7 0.0%
Totals Coverage Status
Change from base Build 1006: 0.0%
Covered Lines: 2644
Relevant Lines: 4896

💛 - Coveralls

@IOrlandoni
Copy link
Member

Thank you for the pull request.

Could you reflect this change with a minimum description in the docs? I'm guessing this would be the right place.

Also, if possible, could we have a test for it? If it can't be unit tested (which I think it can't), you can create a new graph on /cypress/platform/. Those get checked for backwards compatibility on each build.

@knsv
Copy link
Collaborator

knsv commented Sep 30, 2019

The documentation could be solved by adding a default setting in mermaidAPI.js with the corresponding api. Documentation will then be generated. Se corresponding setting for htmlLabels below:

  flowchart: {
    /**
     * Flag for setting whether or not a html tag should be used for rendering labels
     * on the edges.
     * **Default value true**.
     */
    htmlLabels: true,

@knsv knsv merged commit a922401 into mermaid-js:master Oct 8, 2019
@knsv
Copy link
Collaborator

knsv commented Oct 8, 2019

Thank @volkanunsal!

@mermaid-js mermaid-js locked as resolved and limited conversation to collaborators Oct 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants