From 1bb1c6a2862766838b161e28e36522548b1442d4 Mon Sep 17 00:00:00 2001 From: Hunter Thornsberry Date: Wed, 28 Aug 2024 15:20:24 -0400 Subject: [PATCH 01/19] updated actions to only occur on certain branches --- .github/workflows/ci.yml | 24 ++++++++++++++++- .github/workflows/pr.yml | 56 +++++++++++++++++++++++++++++++++++++++- 2 files changed, 78 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f25c5e1..ab087c6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,7 +1,28 @@ name: CI on: push + branches: + - master +jobs: + quality: + runs-on: ubuntu-latest + permissions: + contents: read + steps: + - name: Checkout + uses: actions/checkout@v4 + + - name: Setup Biome + uses: biomejs/setup-biome@v1 + with: + version: latest + + - name: Run Biome + run: biome ci . # https://biomejs.dev/reference/cli/#biome-ci +on: + release: + types: [released] jobs: quality: runs-on: ubuntu-latest @@ -17,8 +38,9 @@ jobs: version: latest - name: Run Biome - run: biome ci . + run: biome ci . # https://biomejs.dev/reference/cli/#biome-ci publish: + needs: quality runs-on: ubuntu-latest permissions: contents: read diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 208803d..89a6aa0 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -3,7 +3,61 @@ name: Pull Request on: pull_request jobs: + quality: + runs-on: ubuntu-latest + permissions: + contents: read + steps: + - name: Checkout + uses: actions/checkout@v4 + + - name: Setup Biome + uses: biomejs/setup-biome@v1 + with: + version: latest + + - name: Run Biome + run: biome ci . # https://biomejs.dev/reference/cli/#biome-ci + build: + needs: quality + runs-on: ubuntu-latest + steps: + - name: Checkout code + uses: actions/checkout@v4 + + - name: Setup pnpm + uses: pnpm/action-setup@v2 + with: + version: latest + + - name: Install Dependencies + run: pnpm install + + - name: Build Package + run: pnpm build + +on: pull_request + branches: + - 'master' + +jobs: + quality: + runs-on: ubuntu-latest + permissions: + contents: read + steps: + - name: Checkout + uses: actions/checkout@v4 + + - name: Setup Biome + uses: biomejs/setup-biome@v1 + with: + version: latest + + - name: Run Biome + run: biome ci . # https://biomejs.dev/reference/cli/#biome-ci build: + needs: quality runs-on: ubuntu-latest steps: - name: Checkout code @@ -35,4 +89,4 @@ jobs: if: steps.check-version-changed.outputs.changed == 'false' run: | echo "No version change. Please update the package version in package.json" - exit 1 + exit 1 \ No newline at end of file From 3ddf0648fed6239ba39d495df3250ee37c969e1d Mon Sep 17 00:00:00 2001 From: Hunter Thornsberry Date: Wed, 28 Aug 2024 15:26:32 -0400 Subject: [PATCH 02/19] run checks on every push --- .github/workflows/ci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ab087c6..de41e55 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,8 +1,6 @@ name: CI on: push - branches: - - master jobs: quality: runs-on: ubuntu-latest From 55407cc601dbc05a53ea69b4326f5c3d31567940 Mon Sep 17 00:00:00 2001 From: Hunter Thornsberry Date: Wed, 28 Aug 2024 15:56:45 -0400 Subject: [PATCH 03/19] split into separate files --- .github/workflows/ci.yml | 58 +--------------------------------------- 1 file changed, 1 insertion(+), 57 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index de41e55..63411a1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,60 +16,4 @@ jobs: version: latest - name: Run Biome - run: biome ci . # https://biomejs.dev/reference/cli/#biome-ci - -on: - release: - types: [released] -jobs: - quality: - runs-on: ubuntu-latest - permissions: - contents: read - steps: - - name: Checkout - uses: actions/checkout@v4 - - - name: Setup Biome - uses: biomejs/setup-biome@v1 - with: - version: latest - - - name: Run Biome - run: biome ci . # https://biomejs.dev/reference/cli/#biome-ci - publish: - needs: quality - runs-on: ubuntu-latest - permissions: - contents: read - id-token: write - steps: - - name: Checkout code & submodules - uses: actions/checkout@v4 - with: - submodules: true - - - name: Setup pnpm - uses: pnpm/action-setup@v2 - with: - version: latest - - - name: Setup Node.js - uses: actions/setup-node@v4 - with: - node-version: 'latest' - - - name: Install Dependencies - run: pnpm install - - - name: Build Package - run: pnpm run build - - - name: "Publish to NPM" - uses: JS-DevTools/npm-publish@v3 - with: - token: ${{ secrets.NPM_TOKEN }} - access: public - - - name: "Publish to JSR" - run: "pnpm dlx jsr publish" \ No newline at end of file + run: biome ci . # https://biomejs.dev/reference/cli/#biome-ci \ No newline at end of file From 00c777be9a0e6ce6a87f6715091ecee4c9bfdde7 Mon Sep 17 00:00:00 2001 From: Hunter Thornsberry Date: Wed, 28 Aug 2024 15:57:00 -0400 Subject: [PATCH 04/19] update files --- .github/workflows/pr-master.yml | 56 +++++++++++++++++++++++++++++++ .github/workflows/pr.yml | 59 ++------------------------------- .github/workflows/release.yml | 57 +++++++++++++++++++++++++++++++ 3 files changed, 116 insertions(+), 56 deletions(-) create mode 100644 .github/workflows/pr-master.yml create mode 100644 .github/workflows/release.yml diff --git a/.github/workflows/pr-master.yml b/.github/workflows/pr-master.yml new file mode 100644 index 0000000..ebbaeec --- /dev/null +++ b/.github/workflows/pr-master.yml @@ -0,0 +1,56 @@ +name: Pull Request - Master + +on: pull_request + branches: + - 'master' + +jobs: +quality: + runs-on: ubuntu-latest + permissions: + contents: read + steps: + - name: Checkout + uses: actions/checkout@v4 + + - name: Setup Biome + uses: biomejs/setup-biome@v1 + with: + version: latest + + - name: Run Biome + run: biome ci . # https://biomejs.dev/reference/cli/#biome-ci +build: + needs: quality + runs-on: ubuntu-latest + steps: + - name: Checkout code + uses: actions/checkout@v4 + + - name: Setup pnpm + uses: pnpm/action-setup@v2 + with: + version: latest + + - name: Install Dependencies + run: pnpm install + + - name: Build Package + run: pnpm build + + - name: Check if version has been updated + id: check-version-changed + uses: EndBug/version-check@v2 + with: + diff-search: true + + - name: Log when changed + if: steps.check-version-changed.outputs.changed == 'true' + run: | + echo "Version change found in commit ${{ steps.check.outputs.commit }}! New version: ${{ steps.check.outputs.version }} (${{ steps.check.outputs.type }})" + + - name: Log when unchanged + if: steps.check-version-changed.outputs.changed == 'false' + run: | + echo "No version change. Please update the package version in package.json" + exit 1 \ No newline at end of file diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 89a6aa0..dee3591 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -1,6 +1,8 @@ name: Pull Request on: pull_request + branches-ignore: + - 'master' jobs: quality: @@ -34,59 +36,4 @@ jobs: run: pnpm install - name: Build Package - run: pnpm build - -on: pull_request - branches: - - 'master' - -jobs: - quality: - runs-on: ubuntu-latest - permissions: - contents: read - steps: - - name: Checkout - uses: actions/checkout@v4 - - - name: Setup Biome - uses: biomejs/setup-biome@v1 - with: - version: latest - - - name: Run Biome - run: biome ci . # https://biomejs.dev/reference/cli/#biome-ci - build: - needs: quality - runs-on: ubuntu-latest - steps: - - name: Checkout code - uses: actions/checkout@v4 - - - name: Setup pnpm - uses: pnpm/action-setup@v2 - with: - version: latest - - - name: Install Dependencies - run: pnpm install - - - name: Build Package - run: pnpm build - - - name: Check if version has been updated - id: check-version-changed - uses: EndBug/version-check@v2 - with: - diff-search: true - - - name: Log when changed - if: steps.check-version-changed.outputs.changed == 'true' - run: | - echo "Version change found in commit ${{ steps.check.outputs.commit }}! New version: ${{ steps.check.outputs.version }} (${{ steps.check.outputs.type }})" - - - name: Log when unchanged - if: steps.check-version-changed.outputs.changed == 'false' - run: | - echo "No version change. Please update the package version in package.json" - exit 1 \ No newline at end of file + run: pnpm build \ No newline at end of file diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml new file mode 100644 index 0000000..3cef629 --- /dev/null +++ b/.github/workflows/release.yml @@ -0,0 +1,57 @@ +name: Release + +on: + release: + types: [released] + jobs: + quality: + runs-on: ubuntu-latest + permissions: + contents: read + steps: + - name: Checkout + uses: actions/checkout@v4 + + - name: Setup Biome + uses: biomejs/setup-biome@v1 + with: + version: latest + + - name: Run Biome + run: biome ci . # https://biomejs.dev/reference/cli/#biome-ci + publish: + needs: quality + runs-on: ubuntu-latest + permissions: + contents: read + id-token: write + steps: + - name: Checkout code & submodules + uses: actions/checkout@v4 + with: + submodules: true + + - name: Setup pnpm + uses: pnpm/action-setup@v2 + with: + version: latest + + - name: Setup Node.js + uses: actions/setup-node@v4 + with: + node-version: 'latest' + + - name: Install Dependencies + run: pnpm install + + - name: Build Package + run: pnpm run build + + - name: "Publish to NPM" + uses: JS-DevTools/npm-publish@v3 + with: + token: ${{ secrets.NPM_TOKEN }} + access: public + + - name: "Publish to JSR" + run: "pnpm dlx jsr publish" \ No newline at end of file From fc35d1a4b66232bbde1a4fdee7e592424fe2b88e Mon Sep 17 00:00:00 2001 From: Hunter Thornsberry Date: Wed, 28 Aug 2024 16:01:18 -0400 Subject: [PATCH 05/19] just check if master when checking version bumps --- .github/workflows/pr-master.yml | 56 --------------------------------- .github/workflows/pr.yml | 23 +++++++++++++- 2 files changed, 22 insertions(+), 57 deletions(-) delete mode 100644 .github/workflows/pr-master.yml diff --git a/.github/workflows/pr-master.yml b/.github/workflows/pr-master.yml deleted file mode 100644 index ebbaeec..0000000 --- a/.github/workflows/pr-master.yml +++ /dev/null @@ -1,56 +0,0 @@ -name: Pull Request - Master - -on: pull_request - branches: - - 'master' - -jobs: -quality: - runs-on: ubuntu-latest - permissions: - contents: read - steps: - - name: Checkout - uses: actions/checkout@v4 - - - name: Setup Biome - uses: biomejs/setup-biome@v1 - with: - version: latest - - - name: Run Biome - run: biome ci . # https://biomejs.dev/reference/cli/#biome-ci -build: - needs: quality - runs-on: ubuntu-latest - steps: - - name: Checkout code - uses: actions/checkout@v4 - - - name: Setup pnpm - uses: pnpm/action-setup@v2 - with: - version: latest - - - name: Install Dependencies - run: pnpm install - - - name: Build Package - run: pnpm build - - - name: Check if version has been updated - id: check-version-changed - uses: EndBug/version-check@v2 - with: - diff-search: true - - - name: Log when changed - if: steps.check-version-changed.outputs.changed == 'true' - run: | - echo "Version change found in commit ${{ steps.check.outputs.commit }}! New version: ${{ steps.check.outputs.version }} (${{ steps.check.outputs.type }})" - - - name: Log when unchanged - if: steps.check-version-changed.outputs.changed == 'false' - run: | - echo "No version change. Please update the package version in package.json" - exit 1 \ No newline at end of file diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index dee3591..4607505 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -36,4 +36,25 @@ jobs: run: pnpm install - name: Build Package - run: pnpm build \ No newline at end of file + run: pnpm build + version-check: + needs: build + if: github.ref == 'refs/heads/master' + steps: + - name: Check if version has been updated + if: + id: check-version-changed + uses: EndBug/version-check@v2 + with: + diff-search: true + + - name: Log when changed + if: steps.check-version-changed.outputs.changed == 'true' + run: | + echo "Version change found in commit ${{ steps.check.outputs.commit }}! New version: ${{ steps.check.outputs.version }} (${{ steps.check.outputs.type }})" + + - name: Log when unchanged + if: steps.check-version-changed.outputs.changed == 'false' + run: | + echo "No version change. Please update the package version in package.json" + exit 1 \ No newline at end of file From 8be4e8199d6a5377cac401e89ee4d476622d86ea Mon Sep 17 00:00:00 2001 From: Hunter Thornsberry Date: Wed, 28 Aug 2024 16:20:11 -0400 Subject: [PATCH 06/19] spacing --- .github/workflows/release.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 3cef629..52a288f 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -1,8 +1,8 @@ name: Release on: - release: - types: [released] + release: + types: [released] jobs: quality: runs-on: ubuntu-latest From 4c4690e10c06aa976398f65eee1f5e06dd3f3716 Mon Sep 17 00:00:00 2001 From: Hunter Thornsberry Date: Wed, 28 Aug 2024 16:44:36 -0400 Subject: [PATCH 07/19] tabs --- .github/workflows/release.yml | 105 +++++++++++++++++----------------- 1 file changed, 53 insertions(+), 52 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 52a288f..3d47801 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -3,55 +3,56 @@ name: Release on: release: types: [released] - jobs: - quality: - runs-on: ubuntu-latest - permissions: - contents: read - steps: - - name: Checkout - uses: actions/checkout@v4 - - - name: Setup Biome - uses: biomejs/setup-biome@v1 - with: - version: latest - - - name: Run Biome - run: biome ci . # https://biomejs.dev/reference/cli/#biome-ci - publish: - needs: quality - runs-on: ubuntu-latest - permissions: - contents: read - id-token: write - steps: - - name: Checkout code & submodules - uses: actions/checkout@v4 - with: - submodules: true - - - name: Setup pnpm - uses: pnpm/action-setup@v2 - with: - version: latest - - - name: Setup Node.js - uses: actions/setup-node@v4 - with: - node-version: 'latest' - - - name: Install Dependencies - run: pnpm install - - - name: Build Package - run: pnpm run build - - - name: "Publish to NPM" - uses: JS-DevTools/npm-publish@v3 - with: - token: ${{ secrets.NPM_TOKEN }} - access: public - - - name: "Publish to JSR" - run: "pnpm dlx jsr publish" \ No newline at end of file + +jobs: + quality: + runs-on: ubuntu-latest + permissions: + contents: read + steps: + - name: Checkout + uses: actions/checkout@v4 + + - name: Setup Biome + uses: biomejs/setup-biome@v1 + with: + version: latest + + - name: Run Biome + run: biome ci . # https://biomejs.dev/reference/cli/#biome-ci + publish: + needs: quality + runs-on: ubuntu-latest + permissions: + contents: read + id-token: write + steps: + - name: Checkout code & submodules + uses: actions/checkout@v4 + with: + submodules: true + + - name: Setup pnpm + uses: pnpm/action-setup@v2 + with: + version: latest + + - name: Setup Node.js + uses: actions/setup-node@v4 + with: + node-version: 'latest' + + - name: Install Dependencies + run: pnpm install + + - name: Build Package + run: pnpm run build + + - name: "Publish to NPM" + uses: JS-DevTools/npm-publish@v3 + with: + token: ${{ secrets.NPM_TOKEN }} + access: public + + - name: "Publish to JSR" + run: "pnpm dlx jsr publish" \ No newline at end of file From 6398eeddf12cc1b1b7ae2957f61aba598cb13774 Mon Sep 17 00:00:00 2001 From: Hunter Thornsberry Date: Wed, 28 Aug 2024 17:09:12 -0400 Subject: [PATCH 08/19] all prs --- .github/workflows/pr.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 4607505..efa9923 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -1,8 +1,6 @@ name: Pull Request on: pull_request - branches-ignore: - - 'master' jobs: quality: From c663979ee260e4ccedcf2c18ab81a33311e9e161 Mon Sep 17 00:00:00 2001 From: Hunter Thornsberry Date: Wed, 28 Aug 2024 17:14:52 -0400 Subject: [PATCH 09/19] runs-on --- .github/workflows/pr.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index efa9923..a147254 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -37,6 +37,7 @@ jobs: run: pnpm build version-check: needs: build + runs-on: ubuntu-latest if: github.ref == 'refs/heads/master' steps: - name: Check if version has been updated From 97fd35c5ea5f385adcb08df5a6abd651665a398c Mon Sep 17 00:00:00 2001 From: Hunter Thornsberry Date: Wed, 28 Aug 2024 17:28:13 -0400 Subject: [PATCH 10/19] names --- .github/workflows/pr.yml | 2 +- .github/workflows/release.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index a147254..c0925ef 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -1,4 +1,4 @@ -name: Pull Request +name: 'Pull Request' on: pull_request diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 3d47801..7b960e9 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -1,9 +1,9 @@ -name: Release +name: 'Release' on: release: types: [released] - + jobs: quality: runs-on: ubuntu-latest From d5bcc6fd692459e81dd0c0e5a1f77de639eca1e3 Mon Sep 17 00:00:00 2001 From: Hunter Thornsberry Date: Wed, 28 Aug 2024 17:30:08 -0400 Subject: [PATCH 11/19] match protobufs versions --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 243388f..7cbcac4 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@meshtastic/js", - "version": "2.3.7-2", + "version": "2.4.3-0", "description": "Browser library for interfacing with meshtastic devices", "license": "GPL-3.0-only", "scripts": { From e7a3493b6b298717c96de81446c113efe17cc5f3 Mon Sep 17 00:00:00 2001 From: Hunter Thornsberry Date: Wed, 28 Aug 2024 17:44:39 -0400 Subject: [PATCH 12/19] target branch version check --- .github/workflows/pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index c0925ef..c2afa7b 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -38,7 +38,7 @@ jobs: version-check: needs: build runs-on: ubuntu-latest - if: github.ref == 'refs/heads/master' + if: github.base_ref == 'refs/heads/master' steps: - name: Check if version has been updated if: From 8d0e3f88ecca139cd8e6fb408a9119c5e0dea300 Mon Sep 17 00:00:00 2001 From: Hunter Thornsberry Date: Wed, 28 Aug 2024 17:50:12 -0400 Subject: [PATCH 13/19] github.ref --- .github/workflows/pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index c2afa7b..c0925ef 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -38,7 +38,7 @@ jobs: version-check: needs: build runs-on: ubuntu-latest - if: github.base_ref == 'refs/heads/master' + if: github.ref == 'refs/heads/master' steps: - name: Check if version has been updated if: From f165d57ba45f0b4eb2ee5c3ec7540ec801fc5587 Mon Sep 17 00:00:00 2001 From: Hunter Thornsberry Date: Wed, 28 Aug 2024 22:03:52 -0400 Subject: [PATCH 14/19] move version bump to its own yml file --- .github/workflows/pr.yml | 24 +----------------------- .github/workflows/version-bump.yml | 28 ++++++++++++++++++++++++++++ 2 files changed, 29 insertions(+), 23 deletions(-) create mode 100644 .github/workflows/version-bump.yml diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index c0925ef..69dffcf 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -34,26 +34,4 @@ jobs: run: pnpm install - name: Build Package - run: pnpm build - version-check: - needs: build - runs-on: ubuntu-latest - if: github.ref == 'refs/heads/master' - steps: - - name: Check if version has been updated - if: - id: check-version-changed - uses: EndBug/version-check@v2 - with: - diff-search: true - - - name: Log when changed - if: steps.check-version-changed.outputs.changed == 'true' - run: | - echo "Version change found in commit ${{ steps.check.outputs.commit }}! New version: ${{ steps.check.outputs.version }} (${{ steps.check.outputs.type }})" - - - name: Log when unchanged - if: steps.check-version-changed.outputs.changed == 'false' - run: | - echo "No version change. Please update the package version in package.json" - exit 1 \ No newline at end of file + run: pnpm build \ No newline at end of file diff --git a/.github/workflows/version-bump.yml b/.github/workflows/version-bump.yml new file mode 100644 index 0000000..29610f2 --- /dev/null +++ b/.github/workflows/version-bump.yml @@ -0,0 +1,28 @@ +name: 'Version Bump' + +on: pull_request + branches: + - 'master' + +jobs: + version-check: + needs: build + runs-on: ubuntu-latest + steps: + - name: Check if version has been updated + if: + id: check-version-changed + uses: EndBug/version-check@v2 + with: + diff-search: true + + - name: Log when changed + if: steps.check-version-changed.outputs.changed == 'true' + run: | + echo "Version change found in commit ${{ steps.check.outputs.commit }}! New version: ${{ steps.check.outputs.version }} (${{ steps.check.outputs.type }})" + + - name: Log when unchanged + if: steps.check-version-changed.outputs.changed == 'false' + run: | + echo "No version change. Please update the package version in package.json" + exit 1 \ No newline at end of file From 8fc0b1678a530a65b9d536d9f2104d4452482610 Mon Sep 17 00:00:00 2001 From: Hunter Thornsberry Date: Wed, 28 Aug 2024 22:06:55 -0400 Subject: [PATCH 15/19] yml --- .github/workflows/version-bump.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/version-bump.yml b/.github/workflows/version-bump.yml index 29610f2..cf3a251 100644 --- a/.github/workflows/version-bump.yml +++ b/.github/workflows/version-bump.yml @@ -1,8 +1,10 @@ name: 'Version Bump' -on: pull_request - branches: - - 'master' +on: + pull_request: + branches: + - master + jobs: version-check: From d6eaf05eda07103cea45dc1c155012f6529225f2 Mon Sep 17 00:00:00 2001 From: Hunter Thornsberry Date: Wed, 28 Aug 2024 22:19:34 -0400 Subject: [PATCH 16/19] remove needs --- .github/workflows/version-bump.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/version-bump.yml b/.github/workflows/version-bump.yml index cf3a251..d0b0588 100644 --- a/.github/workflows/version-bump.yml +++ b/.github/workflows/version-bump.yml @@ -5,10 +5,8 @@ on: branches: - master - jobs: version-check: - needs: build runs-on: ubuntu-latest steps: - name: Check if version has been updated From da4f3ba31d581cbd5fa7f0f0306229135502fe3c Mon Sep 17 00:00:00 2001 From: Hunter Thornsberry Date: Thu, 29 Aug 2024 16:33:03 -0400 Subject: [PATCH 17/19] version check on release --- .github/workflows/release.yml | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 7b960e9..e3b54c6 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -20,8 +20,28 @@ jobs: - name: Run Biome run: biome ci . # https://biomejs.dev/reference/cli/#biome-ci + version-check: + runs-on: ubuntu-latest + steps: + - name: Check if version has been updated + if: + id: check-version-changed + uses: EndBug/version-check@v2 + with: + diff-search: true + + - name: Log when changed + if: steps.check-version-changed.outputs.changed == 'true' + run: | + echo "Version change found in commit ${{ steps.check.outputs.commit }}! New version: ${{ steps.check.outputs.version }} (${{ steps.check.outputs.type }})" + + - name: Log when unchanged + if: steps.check-version-changed.outputs.changed == 'false' + run: | + echo "No version change. Please update the package version in package.json" + exit 1 publish: - needs: quality + needs: [quality, version-check] runs-on: ubuntu-latest permissions: contents: read From 91b0722b99b58f7bb74cafb82827aa6d9fd5ba03 Mon Sep 17 00:00:00 2001 From: Hunter Thornsberry Date: Thu, 29 Aug 2024 16:59:15 -0400 Subject: [PATCH 18/19] remove version-bump.yml now that its in release.yml --- .github/workflows/version-bump.yml | 28 ---------------------------- 1 file changed, 28 deletions(-) delete mode 100644 .github/workflows/version-bump.yml diff --git a/.github/workflows/version-bump.yml b/.github/workflows/version-bump.yml deleted file mode 100644 index d0b0588..0000000 --- a/.github/workflows/version-bump.yml +++ /dev/null @@ -1,28 +0,0 @@ -name: 'Version Bump' - -on: - pull_request: - branches: - - master - -jobs: - version-check: - runs-on: ubuntu-latest - steps: - - name: Check if version has been updated - if: - id: check-version-changed - uses: EndBug/version-check@v2 - with: - diff-search: true - - - name: Log when changed - if: steps.check-version-changed.outputs.changed == 'true' - run: | - echo "Version change found in commit ${{ steps.check.outputs.commit }}! New version: ${{ steps.check.outputs.version }} (${{ steps.check.outputs.type }})" - - - name: Log when unchanged - if: steps.check-version-changed.outputs.changed == 'false' - run: | - echo "No version change. Please update the package version in package.json" - exit 1 \ No newline at end of file From 24d9d4ae64145beef03a8201292751979f698c23 Mon Sep 17 00:00:00 2001 From: Hunter Thornsberry Date: Wed, 4 Sep 2024 00:26:41 -0400 Subject: [PATCH 19/19] build on ci --- .github/workflows/ci.yml | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 63411a1..1d22d12 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,4 +16,21 @@ jobs: version: latest - name: Run Biome - run: biome ci . # https://biomejs.dev/reference/cli/#biome-ci \ No newline at end of file + run: biome ci . # https://biomejs.dev/reference/cli/#biome-ci + build: + needs: quality + runs-on: ubuntu-latest + steps: + - name: Checkout code + uses: actions/checkout@v4 + + - name: Setup pnpm + uses: pnpm/action-setup@v2 + with: + version: latest + + - name: Install Dependencies + run: pnpm install + + - name: Build Package + run: pnpm build \ No newline at end of file