Fix Windows naming issue with grpc find_library call to protoc #2434
Conversation
WillAyd
changed the title
WillAyd
force-pushed
the
grpc-windows-compat
branch
from
011917e to
cb55cce
Compare
WillAyd
force-pushed
the
grpc-windows-compat
branch
2 times, most recently
from
3b72d8c to
1b0ae1d
Compare
|
Lots of CI failures here but I am of the impression that they don't have anything to do with this change and are pre-existing failures |
|
Upon further inspection I believe the VS/macOS errors are due to an upstream bug - see grpc/grpc-dotnet#2646 @neheb any thoughts on this PR? |
|
pass something like to cppflags. |
WillAyd
force-pushed
the
grpc-windows-compat
branch
from
1b0ae1d to
446cc47
Compare
WillAyd
force-pushed
the
grpc-windows-compat
branch
from
446cc47 to
55d50fa
Compare
|
That helped, although I'm guessing the remaining failures stem from this wrap version being a few years old. @klokik I see from the comments that this file was generated by a script - do you know where that script is? Can we run it against the latest gRPC release? |
|
@neheb looks like we probably need to update this configuration to make it compatiable with newer abseil releases. My guess is that may end up being a significant amount of work. In its current state, the configuration also requires a lot of formatting updates. Should we do the formtting updates as a separate pre-cursor, or is the preference to still just do all of that in one PR? |
|
you can have multiple commits. No issue with that. |
2 participants
No description provided.