From a7ed9ebf582e1110e3eb688801efe0d337b959eb Mon Sep 17 00:00:00 2001 From: Tyler Neely Date: Wed, 4 Nov 2015 14:52:29 -0800 Subject: [PATCH 1/2] Add SCoverage for generating test coverage reports. --- pom.xml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pom.xml b/pom.xml index bed4b6084..c3b841b75 100644 --- a/pom.xml +++ b/pom.xml @@ -261,6 +261,11 @@ + + org.scoverage + scoverage-maven-plugin + 1.0.4 + net.alchim31.maven scala-maven-plugin From d2580266d6fad6bae185fc2d53eeedb1087c95aa Mon Sep 17 00:00:00 2001 From: Tyler Neely Date: Wed, 11 Nov 2015 10:16:48 -0800 Subject: [PATCH 2/2] Document test coverage in contribution guide. --- docs/docs/contributing.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/docs/contributing.md b/docs/docs/contributing.md index a6a4fec41..33200cc64 100644 --- a/docs/docs/contributing.md +++ b/docs/docs/contributing.md @@ -17,6 +17,9 @@ title: Contributor Guidelines - If the change is a bugfix, then the added tests must fail without the patch as a safeguard against future regressions. +- Changes should not result in a drop in code coverage. Coverage may be + checked by running `mvn scoverage:check` + ## Contributing Documentation -We heartily welcome contributions to Chronos's documentation. Documentation should be submitted as a pull request againstthe `master` branch and published to our GitHub pages site by a Chronos committer using the instructions in [docs/README.md](https://github.com/mesos/chronos/tree/master/docs). \ No newline at end of file +We heartily welcome contributions to Chronos's documentation. Documentation should be submitted as a pull request againstthe `master` branch and published to our GitHub pages site by a Chronos committer using the instructions in [docs/README.md](https://github.com/mesos/chronos/tree/master/docs).