[asynctp] Passes, ops #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
IvanKobzarev
force-pushed
the
IvanKobzarev/stack/1
branch
from
859e93e to
17d95c7
Compare
IvanKobzarev
force-pushed
the
IvanKobzarev/stack/1
branch
from
17d95c7 to
d62bf1c
Compare
fmassa
reviewed
Sep 29, 2025
Contributor
fmassa
left a comment
fmassa
left a comment
There was a problem hiding this comment.
LGTM in general, but I think there is a leftover change that needs to be changed prior to merging.
examples/example_llama3.py
Outdated
| mp_policy, | ||
| compile=True, | ||
| repeated_subgraphs=True, | ||
| enable_asynctp=enable_asynctp, |
Contributor
There was a problem hiding this comment.
I think this is leftover from the previous PR?
Contributor
Author
There was a problem hiding this comment.
Yes, will remove it.
stack-info: PR: #167, branch: IvanKobzarev/stack/1
IvanKobzarev
force-pushed
the
IvanKobzarev/stack/1
branch
from
d62bf1c to
89afcff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
[asynctp] Passes, ops