Enabling real PP run on 8 GPUs #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
sanketpurandare
requested review from
ezyang,
fmassa,
wconstab and
xmfan
and removed request for
fmassa
wconstab
reviewed
Nov 4, 2025
examples/example_ds3_pp.py
Outdated
| 2: [2, 6], | ||
| 3: [3, 7], | ||
| } | ||
| if fake_evaluate: |
Contributor
There was a problem hiding this comment.
is it important to maintain 2 paths one for 8 stage one for 4 stage? if not it'd be nice to clean it up and have only one codepath
Member
There was a problem hiding this comment.
Second this, just get a 8 gpu devserver pls
Contributor
Author
There was a problem hiding this comment.
Unified the code path
xmfan
approved these changes
Nov 4, 2025
zhxchen17
added a commit
to zhxchen17/autoparallel
that referenced
this pull request
Nov 4, 2025
Summary: the issue from torch nightly has been fixed for the new export API. relanding. Test Plan: Also tested on meta-pytorch#227 ``` =================================================================================== test session starts =================================================================================== platform linux -- Python 3.12.11, pytest-7.3.2, pluggy-1.6.0 rootdir: /data/users/zhxchen17/autoparallel plugins: xdoctest-1.1.0, hypothesis-5.35.1, xdist-3.3.1, subtests-0.13.1, rerunfailures-14.0, flakefinder-1.1.0, cpp-2.3.0, anyio-4.10.0 collected 21 items tests/test_aot_eager.py ..x [ 14%] tests/test_api.py .... [ 33%] tests/test_dtensor.py .... [ 52%] tests/test_optimize_placement.py ........ [ 90%] tests/test_ordered_sharding.py .. [100%] ======================================================================== 20 passed, 1 xfailed in 86.30s (0:01:26) ========================================================================= ```
zhxchen17
added a commit
to zhxchen17/autoparallel
that referenced
this pull request
Nov 4, 2025
Summary: the issue from torch nightly has been fixed for the new export API. relanding. Test Plan: Also tested on meta-pytorch#227 ``` =================================================================================== test session starts =================================================================================== platform linux -- Python 3.12.11, pytest-7.3.2, pluggy-1.6.0 rootdir: /data/users/zhxchen17/autoparallel plugins: xdoctest-1.1.0, hypothesis-5.35.1, xdist-3.3.1, subtests-0.13.1, rerunfailures-14.0, flakefinder-1.1.0, cpp-2.3.0, anyio-4.10.0 collected 21 items tests/test_aot_eager.py ..x [ 14%] tests/test_api.py .... [ 33%] tests/test_dtensor.py .... [ 52%] tests/test_optimize_placement.py ........ [ 90%] tests/test_ordered_sharding.py .. [100%] ======================================================================== 20 passed, 1 xfailed in 86.30s (0:01:26) ========================================================================= ```
sanketpurandare
changed the title
zhxchen17
added a commit
to zhxchen17/autoparallel
that referenced
this pull request
Nov 5, 2025
Summary: the issue from torch nightly has been fixed for the new export API. relanding. Test Plan: Also tested on meta-pytorch#227 ``` =================================================================================== test session starts =================================================================================== platform linux -- Python 3.12.11, pytest-7.3.2, pluggy-1.6.0 rootdir: /data/users/zhxchen17/autoparallel plugins: xdoctest-1.1.0, hypothesis-5.35.1, xdist-3.3.1, subtests-0.13.1, rerunfailures-14.0, flakefinder-1.1.0, cpp-2.3.0, anyio-4.10.0 collected 21 items tests/test_aot_eager.py ..x [ 14%] tests/test_api.py .... [ 33%] tests/test_dtensor.py .... [ 52%] tests/test_optimize_placement.py ........ [ 90%] tests/test_ordered_sharding.py .. [100%] ======================================================================== 20 passed, 1 xfailed in 86.30s (0:01:26) ========================================================================= ```
zhxchen17
added a commit
to zhxchen17/autoparallel
that referenced
this pull request
Nov 7, 2025
Summary: the issue from torch nightly has been fixed for the new export API. relanding. Test Plan: Also tested on meta-pytorch#227 ``` =================================================================================== test session starts =================================================================================== platform linux -- Python 3.12.11, pytest-7.3.2, pluggy-1.6.0 rootdir: /data/users/zhxchen17/autoparallel plugins: xdoctest-1.1.0, hypothesis-5.35.1, xdist-3.3.1, subtests-0.13.1, rerunfailures-14.0, flakefinder-1.1.0, cpp-2.3.0, anyio-4.10.0 collected 21 items tests/test_aot_eager.py ..x [ 14%] tests/test_api.py .... [ 33%] tests/test_dtensor.py .... [ 52%] tests/test_optimize_placement.py ........ [ 90%] tests/test_ordered_sharding.py .. [100%] ======================================================================== 20 passed, 1 xfailed in 86.30s (0:01:26) ========================================================================= ```
zhxchen17
added a commit
to zhxchen17/autoparallel
that referenced
this pull request
Nov 12, 2025
Summary: the issue from torch nightly has been fixed for the new export API. relanding. Test Plan: Also tested on meta-pytorch#227 ``` =================================================================================== test session starts =================================================================================== platform linux -- Python 3.12.11, pytest-7.3.2, pluggy-1.6.0 rootdir: /data/users/zhxchen17/autoparallel plugins: xdoctest-1.1.0, hypothesis-5.35.1, xdist-3.3.1, subtests-0.13.1, rerunfailures-14.0, flakefinder-1.1.0, cpp-2.3.0, anyio-4.10.0 collected 21 items tests/test_aot_eager.py ..x [ 14%] tests/test_api.py .... [ 33%] tests/test_dtensor.py .... [ 52%] tests/test_optimize_placement.py ........ [ 90%] tests/test_ordered_sharding.py .. [100%] ======================================================================== 20 passed, 1 xfailed in 86.30s (0:01:26) ========================================================================= ```
zhxchen17
added a commit
that referenced
this pull request
Nov 12, 2025
Summary: the issue from torch nightly has been fixed for the new export API. relanding. Test Plan: Also tested on #227 ``` =================================================================================== test session starts =================================================================================== platform linux -- Python 3.12.11, pytest-7.3.2, pluggy-1.6.0 rootdir: /data/users/zhxchen17/autoparallel plugins: xdoctest-1.1.0, hypothesis-5.35.1, xdist-3.3.1, subtests-0.13.1, rerunfailures-14.0, flakefinder-1.1.0, cpp-2.3.0, anyio-4.10.0 collected 21 items tests/test_aot_eager.py ..x [ 14%] tests/test_api.py .... [ 33%] tests/test_dtensor.py .... [ 52%] tests/test_optimize_placement.py ........ [ 90%] tests/test_ordered_sharding.py .. [100%] ======================================================================== 20 passed, 1 xfailed in 86.30s (0:01:26) ========================================================================= ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Real run:
torchrun --standalone --nproc-per-node 8 examples/example_ds3_pp.pyFake run:
torchrun --standalone --nproc-per-node 4 examples/example_ds3_pp.py --fake-evaluate