Skip to content

keep input mutations in the joint graph #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

keep input mutations in the joint graph #32

merged 1 commit into from
Jul 17, 2025

Conversation

@bdhirsh
Copy link
Contributor

@bdhirsh bdhirsh commented Jul 7, 2025

can't land until pytorch/pytorch#157730 lands first.

After patching this into Francisco's deepseek example from #29, I hit:

[rank0]:   File "/data/users/hirsheybar/c/pytorch/autoparallel/autoparallel/utils.py", line 61, in propagate_tensor_meta
[rank0]:     assert op in supported_ops, (
[rank0]: AssertionError: aten.copy_.default strategy doesn't have input_specs, only harcoded {supported_ops} for now

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 7, 2025
@bdhirsh bdhirsh mentioned this pull request Jul 7, 2025
Draft
13 tasks
@wconstab wconstab force-pushed the input_mutation_in_graph branch from 0142dae to f26b8ef Compare July 17, 2025 23:02
@wconstab wconstab merged commit 233d68b into main Jul 17, 2025
6 checks passed
@wconstab wconstab deleted the input_mutation_in_graph branch July 17, 2025 23:34
@fmassa
Copy link
Contributor

fmassa commented Jul 18, 2025

@ezyang will this still be needed after you AotAutograd refactor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bdhirsh @fmassa @ezyang @wconstab @facebook-github-bot