From c69e8942335ed7d77af277fd31355ad0c0f893a2 Mon Sep 17 00:00:00 2001 From: TobiasNx <61879957+TobiasNx@users.noreply.github.com> Date: Thu, 17 Oct 2024 12:31:47 +0200 Subject: [PATCH] Apply suggestions from code review By @dr0i Co-authored-by: Pascal Christoph --- .../src/main/java/org/metafacture/xml/GenericXmlHandler.java | 4 ++-- .../src/main/java/org/metafacture/xml/SimpleXmlEncoder.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/metafacture-xml/src/main/java/org/metafacture/xml/GenericXmlHandler.java b/metafacture-xml/src/main/java/org/metafacture/xml/GenericXmlHandler.java index b28aaea7..6c406ffa 100644 --- a/metafacture-xml/src/main/java/org/metafacture/xml/GenericXmlHandler.java +++ b/metafacture-xml/src/main/java/org/metafacture/xml/GenericXmlHandler.java @@ -34,11 +34,11 @@ * @author Markus Michael Geipel * */ -@Description("A generic xml reader. Separates XML data in distrinct records with the defined record tag name (default: `recordtagname=\"record\"`)" + +@Description("A generic XML reader. Separates XML data in distinct records with the defined record tag name (default: `recordtagname=\"record\"`)" + "If no matching record tag is found, the output will be empty." + "The handler breaks down XML elements with simple string values and optional attributes" + "into entities with a value subfield (name configurable) and additional subfields for each attribute." + - "Record tag and value tag names can be configured, also attributes can get get an attributeMarker.") + "Record tag and value tag names can be configured. Attributes can get an attributeMarker.") @In(XmlReceiver.class) @Out(StreamReceiver.class) @FluxCommand("handle-generic-xml") diff --git a/metafacture-xml/src/main/java/org/metafacture/xml/SimpleXmlEncoder.java b/metafacture-xml/src/main/java/org/metafacture/xml/SimpleXmlEncoder.java index 3010c804..eb39d667 100644 --- a/metafacture-xml/src/main/java/org/metafacture/xml/SimpleXmlEncoder.java +++ b/metafacture-xml/src/main/java/org/metafacture/xml/SimpleXmlEncoder.java @@ -47,7 +47,7 @@ * @author Christoph Böhme * */ -@Description("Encodes a stream as xml. Defaults: `rootTag=\"records\"`, `recordTag=\"record\"`, no attributeMarker.") +@Description("Encodes a stream as XML. Defaults: `rootTag=\"records\"`, `recordTag=\"record\"`, no attributeMarker.") @In(StreamReceiver.class) @Out(String.class) @FluxCommand("stream-to-xml")