Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD support of a custom separator as FLUX parameter for CsvDecoder #319

Closed
wants to merge 3 commits into from

Conversation

hagbeck
Copy link
Contributor

@hagbeck hagbeck commented Apr 9, 2020

assume that the first char of a String is meant for this case (reason: char is needed for CSVReader)

hagbeck added 3 commits April 9, 2020 16:50
…t the first char of a String is meant for this case (reason: char is needed for CSVReader)
…t for char type again because of backward compatibility.
@dr0i dr0i self-assigned this Apr 16, 2020
@dr0i
Copy link
Member

dr0i commented Apr 16, 2020

Hi @hagbeck, thx for the PR!
I opened another PR based on your PR: #321.
This is because of following the https://github.com/metafacture/metafacture-core/wiki/Contributor-Guidelines (which I just updated).

Most of all I squashed the 3 commits to one.

@dr0i
Copy link
Member

dr0i commented Apr 16, 2020

I close this PR. The code from this PR is merged into master with #321.

@dr0i dr0i closed this Apr 16, 2020
blackwinter pushed a commit that referenced this pull request Dec 13, 2024
blackwinter pushed a commit that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants