Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Completely remove support for ironic-inspector #483

Merged
merged 1 commit into from
Apr 19, 2024
Merged

⚠️ Completely remove support for ironic-inspector #483

merged 1 commit into from
Apr 19, 2024

Conversation

dtantsur
Copy link
Member

@dtantsur dtantsur commented Mar 6, 2024

No description provided.

@metal3-io-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 6, 2024
@dtantsur
Copy link
Member Author

dtantsur commented Mar 6, 2024

/test ?

@metal3-io-bot
Copy link
Contributor

@dtantsur: The following commands are available to trigger required jobs:

  • /test markdownlint
  • /test shellcheck

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtantsur
Copy link
Member Author

dtantsur commented Mar 6, 2024

/test-centos-integration-main

@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2024
@dtantsur dtantsur mentioned this pull request Mar 18, 2024
Open
@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2024
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2024
@dtantsur dtantsur changed the title ⚠️ Complete remove support for ironic-inspector ⚠️ Completely remove support for ironic-inspector Mar 26, 2024
@dtantsur
Copy link
Member Author

/test-centos-integration-main

lentzi90
lentzi90 reviewed Apr 3, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Is it ready?

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2024
@dtantsur
Completely remove support for ironic-inspector
4fe398f 
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2024
@dtantsur dtantsur marked this pull request as ready for review April 18, 2024 14:17
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2024
@dtantsur
Copy link
Member Author

This looks good! Is it ready?

I wanted to wait for #482 to merge before causing a lot of conflicts for it. Now it's ready to go!

@dtantsur
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

lentzi90
lentzi90 reviewed Apr 19, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
@metal3-io-bot metal3-io-bot merged commit cfac9aa into metal3-io:main Apr 19, 2024
9 checks passed
@dtantsur dtantsur deleted the no-inspector branch April 19, 2024 11:17
@kmg1905 kmg1905 mentioned this pull request Jul 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dtantsur @metal3-io-bot @elfosardo @lentzi90