-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First integration test. #491
Merged
Merged
+513
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57eee52
to
f1afae5
Compare
aviramha
reviewed
Oct 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress!
a753250
to
50024b0
Compare
aviramha
reviewed
Oct 5, 2022
50024b0
to
260e97b
Compare
t4lz
commented
Oct 5, 2022
6aa14b0
to
6d93c8e
Compare
3bcfad8
to
f4371c2
Compare
aviramha
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
51f87ce
to
35eb466
Compare
Add a feature for the layer to connect over tcp instead of starting an agent with kuberenetes. Load the layer into a flask server process, have it connect to the tests code over TCP, verify correct messages from layer, send (fake) TCP notifications to the layer and check app output. Since the `build_mirrord` job builds the library anyways, use that artifact for running the test on ubuntu. For MacOS just build the library in a step in the test job. Make rebuilding the library from code the defualt when running the integration tests, with an the option to use a prebuilt lib, for CI. Because building locally is fast and that way when testing locally you always test the latest layer code. Make the `test_mirrord_layer` job only run unit tests. Add CI dummies for the new jobs. Co-authored-by: Aviram Hassan <aviram@metalbear.co>
ab79035
to
0f84867
Compare
aviramha
approved these changes
Oct 7, 2022
tamasfe
pushed a commit
to tamasfe/mirrord
that referenced
this pull request
Oct 10, 2022
Add a feature for the layer to connect over tcp instead of starting an agent with kuberenetes. Load the layer into a flask server process, have it connect to the tests code over TCP, verify correct messages from layer, send (fake) TCP notifications to the layer and check app output. Since the `build_mirrord` job builds the library anyways, use that artifact for running the test on ubuntu. For MacOS just build the library in a step in the test job. Make rebuilding the library from code the defualt when running the integration tests, with an the option to use a prebuilt lib, for CI. Because building locally is fast and that way when testing locally you always test the latest layer code. Make the `test_mirrord_layer` job only run unit tests. Add CI dummies for the new jobs. Co-authored-by: Aviram Hassan <aviram@metalbear.co>
nope we do want to see that it builds for the target
…On Tue, Oct 4, 2022 at 5:09 PM t4lz ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/ci.yaml
<#491 (comment)>:
> @@ -168,10 +168,47 @@ jobs:
- run: sudo apt install -y libpcap-dev cmake
- run: cargo +nightly build --manifest-path=./Cargo.toml
+ integration_tests:
+ strategy:
+ matrix:
+ os: [ubuntu-latest, macos-12, macos-11]
+ target:
+ [x86_64-unknown-linux-gnu, x86_64-apple-darwin, aarch64-apple-darwin]
Oh, so should we also remove it from test_mirrord_layer_cli?
—
Reply to this email directly, view it on GitHub
<#491 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ2LCBFPDQGSR6PJXJNUZWTWBQ27ZANCNFSM6AAAAAAQ4SLHSI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#472
#450