Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First integration test. #491

Merged
merged 1 commit into from
Oct 7, 2022
Merged

First integration test. #491

merged 1 commit into from
Oct 7, 2022

Conversation

t4lz
Copy link
Member

@t4lz t4lz commented Oct 4, 2022

@t4lz t4lz marked this pull request as draft October 4, 2022 13:26
@t4lz t4lz force-pushed the integration_start branch from 57eee52 to f1afae5 Compare October 4, 2022 13:26
Copy link
Member

@aviramha aviramha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress!

@t4lz t4lz force-pushed the integration_start branch 9 times, most recently from a753250 to 50024b0 Compare October 4, 2022 18:44
@t4lz t4lz force-pushed the integration_start branch from 50024b0 to 260e97b Compare October 5, 2022 07:48
@t4lz t4lz force-pushed the integration_start branch 15 times, most recently from 6aa14b0 to 6d93c8e Compare October 6, 2022 13:23
@t4lz t4lz force-pushed the integration_start branch 8 times, most recently from 3bcfad8 to f4371c2 Compare October 6, 2022 16:52
@t4lz t4lz marked this pull request as ready for review October 6, 2022 17:18
@t4lz t4lz requested a review from aviramha October 6, 2022 17:19
Copy link
Member

@aviramha aviramha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@t4lz t4lz force-pushed the integration_start branch from 51f87ce to 35eb466 Compare October 7, 2022 08:26
Add a feature for the layer to connect over tcp instead of starting
an agent with kuberenetes.

Load the layer into a flask server process, have it connect to the
tests code over TCP, verify correct messages from layer, send
(fake) TCP notifications to the layer and check app output.

Since the `build_mirrord` job builds the library anyways, use that
artifact for running the test on ubuntu. For MacOS just build the
library in a step in the test job.

Make rebuilding the library from code the defualt when running the
integration tests, with an the option to use a prebuilt lib, for
CI. Because building locally is fast and that way when testing
locally you always test the latest layer code.

Make the `test_mirrord_layer` job only run unit tests.

Add CI dummies for the new jobs.

Co-authored-by: Aviram Hassan <aviram@metalbear.co>
@t4lz t4lz force-pushed the integration_start branch from ab79035 to 0f84867 Compare October 7, 2022 09:03
@t4lz t4lz merged commit 6a1d807 into metalbear-co:main Oct 7, 2022
tamasfe pushed a commit to tamasfe/mirrord that referenced this pull request Oct 10, 2022
Add a feature for the layer to connect over tcp instead of starting
an agent with kuberenetes.

Load the layer into a flask server process, have it connect to the
tests code over TCP, verify correct messages from layer, send
(fake) TCP notifications to the layer and check app output.

Since the `build_mirrord` job builds the library anyways, use that
artifact for running the test on ubuntu. For MacOS just build the
library in a step in the test job.

Make rebuilding the library from code the defualt when running the
integration tests, with an the option to use a prebuilt lib, for
CI. Because building locally is fast and that way when testing
locally you always test the latest layer code.

Make the `test_mirrord_layer` job only run unit tests.

Add CI dummies for the new jobs.

Co-authored-by: Aviram Hassan <aviram@metalbear.co>
@aviramha
Copy link
Member

aviramha commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants